Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure API updates #79583

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Azure API updates #79583

merged 4 commits into from
Jul 1, 2019

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jul 1, 2019 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:

  • Update azure-sdk-for-go/services/containerregistry to 2018-09-01
  • Update azure-sdk-for-go/services/network to 2018-08-01

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update Azure API versions (containerregistry --> 2018-09-01, network --> 2018-08-01)

@justaugustus
Update azure-sdk-for-go/services/containerregistry to 2018-09-01
a64cf7a 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
Update vendor
97bc3a3 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
Update azure-sdk-for-go/services/network to 2018-08-01
f33198b 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
Update vendor
df3a7d4 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 1, 2019
@justaugustus
Copy link
Member Author

/assign @feiskyer @andyzhangx @khenidak
/sig azure
/priority important-soon
/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 1, 2019
@k8s-ci-robot k8s-ci-robot added sig/azure priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 1, 2019
@feiskyer
Copy link
Member

feiskyer commented Jul 1, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer
Copy link
Member

feiskyer commented Jul 1, 2019

The changes looks good, let's check what CI would report.

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure

@justaugustus
Copy link
Member Author

(Can't tell if this is a flake or not)
/test pull-kubernetes-e2e-aks-engine-azure

@justaugustus
Copy link
Member Author

Actually, this job seems to fail pretty consistently on that Up step: https://prow.k8s.io/job-history/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-aks-engine-azure
We should look into it, but not block on it here.

@justaugustus
Copy link
Member Author

Created #79597 to investigate the pull-kubernetes-e2e-aks-engine-azure failure.

@justaugustus justaugustus mentioned this pull request Jul 1, 2019
Closed
@justaugustus
Copy link
Member Author

For deps:
/assign @cblecker @dims @BenTheElder

@feiskyer
Copy link
Member

feiskyer commented Jul 1, 2019

The failure is not related to this change, need to investigate why it's failing again.

feiskyer
feiskyer reviewed Jul 1, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2019
BenTheElder
BenTheElder approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
for vendor

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, feiskyer, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2019
@BenTheElder
Copy link
Member

/hold
do we care about the optional e2e failure?
unhold if not :-)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2019
@justaugustus
Copy link
Member Author

@BenTheElder -- nope, but thanks for checking! I've opened #79597 to track that.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@BenTheElder
Copy link
Member

clearing it to make the bots go away 🙃
/skip
[may need to be done again when the failure comes back in, but before the bot comments again..]

@k8s-ci-robot
Copy link
Contributor

@justaugustus: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure df3a7d4 link /test pull-kubernetes-e2e-aks-engine-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 38e8b8a into kubernetes:master Jul 1, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@nilo19 nilo19 mentioned this pull request Jul 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@BenTheElder BenTheElder BenTheElder approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@karataliu karataliu Awaiting requested review from karataliu

Assignees

@dims dims

@feiskyer feiskyer

@BenTheElder BenTheElder

@cblecker cblecker

@andyzhangx andyzhangx

@khenidak khenidak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
9 participants
@justaugustus @feiskyer @k8s-ci-robot @BenTheElder @fejta-bot @dims @cblecker @andyzhangx @khenidak