Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use correct function to remove etcd member #79326

Merged
merged 1 commit into from
Jun 24, 2019
Merged

fix: Use correct function to remove etcd member #79326

merged 1 commit into from
Jun 24, 2019

Conversation

bradbeam
Copy link
Contributor

@bradbeam bradbeam commented Jun 24, 2019 •
edited
Loading

Signed-off-by: Brad Beam brad.beam@talos-systems.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

This uses the correct function name for removing the etcd member from the cluster during a kubeadm reset.

Which issue(s) this PR fixes:

Fixes #79324

Does this PR introduce a user-facing change?:

Fix remove the etcd member from the cluster during a kubeadm reset.

@bradbeam
fix: Use correct function to remove etcd member
b646ac4 
Signed-off-by: Brad Beam <brad.beam@talos-systems.com>
@k8s-ci-robot
Copy link
Contributor

Welcome @bradbeam!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @bradbeam. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 24, 2019
@k8s-ci-robot k8s-ci-robot requested review from detiber and dixudx June 24, 2019 03:47
draveness
draveness reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@draveness draveness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2019
@draveness
Copy link
Contributor

Please specify a release note in the description

draveness
draveness approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@draveness draveness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2019
@draveness
Copy link
Contributor

cc/ @kubernetes/sig-cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2019
@SataQiu
Copy link
Member

SataQiu commented Jun 24, 2019

/lgtm

@SataQiu
Copy link
Member

SataQiu commented Jun 24, 2019

/cc @neolit123

@k8s-ci-robot k8s-ci-robot requested a review from neolit123 June 24, 2019 04:00
@draveness
Copy link
Contributor

/retest

rosti
rosti approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bradbeam !
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradbeam, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2019
@draveness
Copy link
Contributor

Do we need to create a patch release 1.15.1 with this fix?

@rosti
Copy link
Contributor

rosti commented Jun 24, 2019

@draveness Yes, we can cherry pick it in 1.15.

@draveness draveness mentioned this pull request Jun 24, 2019
Merged
@k8s-ci-robot k8s-ci-robot merged commit 80a3177 into kubernetes:master Jun 24, 2019
k8s-ci-robot added a commit that referenced this pull request Jun 24, 2019
@k8s-ci-robot
Merge pull request #79331 from draveness/automated-cherry-pick-of-#79…
5b2266b 
…326-upstream-release-1.15

Automated cherry pick of #79326: fix: Use correct function to remove etcd member
@SataQiu SataQiu mentioned this pull request Jun 30, 2019
Closed
@heckad
Copy link

heckad commented Jul 16, 2019

When 1.15.1 will be released?

@bradbeam bradbeam deleted the etcdleave branch July 16, 2019 16:02
@neolit123
Copy link
Member

When 1.15.1 will be released?

probably in the next couple of weeks.
the release team does not know yet.

@neolit123
Copy link
Member

the release team does not know yet.

scratch that, it's 2019-07-18
https://github.com/kubernetes/sig-release/pull/686/files#diff-3b6790bdeadbf26945fec2a2336dbd2aR50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draveness draveness draveness approved these changes

@rosti rosti rosti approved these changes

@detiber detiber Awaiting requested review from detiber

@dixudx dixudx Awaiting requested review from dixudx

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@draveness draveness

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeadm: reset fails to remove etcd member
7 participants
@bradbeam @k8s-ci-robot @draveness @SataQiu @rosti @heckad @neolit123