Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cleanup feature gates for CSIPersistentVolume #79309

Merged
merged 1 commit into from
Jun 25, 2019
Merged

feat: cleanup feature gates for CSIPersistentVolume #79309

merged 1 commit into from
Jun 25, 2019

Conversation

draveness
Copy link
Contributor

@draveness draveness commented Jun 23, 2019 •
edited
Loading

/kind cleanup

What this PR does / why we need it:

CSIPersistentVolume has already graduated to GA two releases ago, we could remove it in release 1.16

Which issue(s) this PR fixes:

Fix: #79308

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove CSIPersistentVolume feature gates

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 23, 2019
@draveness draveness mentioned this pull request Jun 23, 2019
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 23, 2019
@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and gmarek June 23, 2019 08:50
@draveness
Copy link
Contributor Author

/priority important-soon
/sig storage

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 23, 2019
@draveness
Copy link
Contributor Author

/assign @vladimirvivien @lavalamp

@draveness draveness force-pushed the feature/cleanup-CSIPersistentVolume-feature-gates branch from d56a7ec to fc63859 Compare June 23, 2019 08:53
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2019
@draveness draveness marked this pull request as ready for review June 23, 2019 08:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2019
mattjmcnaughton
mattjmcnaughton approved these changes Jun 23, 2019
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Modulo the Bazel changes. Ensure if those are flake or if we need to run an update script.

/test pull-kubernetes-bazel-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 23, 2019
@liggitt
Copy link
Member

liggitt commented Jun 24, 2019 •
edited
Loading

the RBAC test fixture data needs to be regenerated, see the unit test failure output for instructions on how to do that

@draveness draveness force-pushed the feature/cleanup-CSIPersistentVolume-feature-gates branch from fc63859 to ad392e3 Compare June 24, 2019 01:33
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 24, 2019
@draveness
Copy link
Contributor Author

draveness commented Jun 24, 2019 via email

@draveness
Copy link
Contributor Author

draveness commented Jun 24, 2019 via email

@draveness
Copy link
Contributor Author

the RBAC test fixture data needs to be regenerated, see the unit test failure output for instructions on how to do that

Thanks Jordan, the comments have been addressed, please take another look.

@draveness draveness force-pushed the feature/cleanup-CSIPersistentVolume-feature-gates branch from ad392e3 to b470b08 Compare June 25, 2019 00:58
@draveness draveness force-pushed the feature/cleanup-CSIPersistentVolume-feature-gates branch from b470b08 to 8e9472b Compare June 25, 2019 01:00
@draveness
Copy link
Contributor Author

/retest

@draveness
Copy link
Contributor Author

draveness commented Jun 25, 2019 via email

@liggitt
Copy link
Member

liggitt commented Jun 25, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit ad09532 into kubernetes:master Jun 25, 2019
@draveness draveness deleted the feature/cleanup-CSIPersistentVolume-feature-gates branch July 1, 2019 08:42
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
@liggitt liggitt removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@mattjmcnaughton mattjmcnaughton mattjmcnaughton approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@vladimirvivien vladimirvivien

@lavalamp lavalamp

@liggitt liggitt

@mattjmcnaughton mattjmcnaughton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Cleanup feature gates which should be removed in 1.16
6 participants
@draveness @liggitt @k8s-ci-robot @mattjmcnaughton @vladimirvivien @lavalamp