Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump prometheus common to v0.1.0 #79261

Merged
merged 5 commits into from
Sep 23, 2019
Merged

feat: bump prometheus common to v0.1.0 #79261

merged 5 commits into from
Sep 23, 2019

Conversation

draveness
Copy link
Contributor

@draveness draveness commented Jun 21, 2019 •
edited
Loading

/kind bug

What this PR does / why we need it:

Pin several dependencies to specific versions

Which issue(s) this PR fixes:

xref: #79234

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 21, 2019
@draveness
Copy link
Contributor Author

cc/ @dims

Do I need to update the vendor files with go mod vendor cmd?

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jun 21, 2019
@k8s-ci-robot k8s-ci-robot requested review from brendandburns, smarterclayton and a team June 21, 2019 04:45
@cblecker
Copy link
Member

Instructions: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/vendor.md

@draveness draveness force-pushed the feature/bump-prometheus-common branch from d94605b to e6fce51 Compare June 21, 2019 08:49
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2019
@draveness draveness marked this pull request as ready for review June 21, 2019 08:50
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 21, 2019
@draveness
Copy link
Contributor Author

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 21, 2019
@liggitt
Copy link
Member

liggitt commented Sep 20, 2019

/assign @brancz

@brancz
Copy link
Member

brancz commented Sep 20, 2019

Happy to give this a pass once v0.9.4 or prometheus/client_golang and v0.4.1 prometheus/common is used here.

@draveness
Copy link
Contributor Author

Happy to give this a pass once v0.9.4 or prometheus/client_golang and v0.4.1 prometheus/common is used here.

I'll bump the version

@draveness draveness force-pushed the feature/bump-prometheus-common branch from 468d454 to 57da7a3 Compare September 22, 2019 12:04
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 22, 2019
@brancz
Copy link
Member

brancz commented Sep 22, 2019

Looks good from sig instrumentation.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2019
@k8s-ci-robot
Copy link
Contributor

@draveness: GitHub didn't allow me to request PR reviews from the following users: for, approval.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Looks good from sig instrumentation.

/lgtm

/cc @liggitt for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness
Copy link
Contributor Author

/assign @dims @BenTheElder

@dims
Copy link
Member

dims commented Sep 23, 2019

cc @DirectXMan12

liggitt
liggitt reviewed Sep 23, 2019
View reviewed changes
go.mod
github.com/prometheus/client_model v0.0.0-20180712105110-5c3871d89910
github.com/prometheus/common v0.0.0-20181126121408-4724e9255275
github.com/prometheus/client_golang v0.9.4
github.com/prometheus/client_model v0.0.0-20190129233127-fd36f4220a90
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a tagged release of github.com/prometheus/client_model we should use?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, looks like this is the SHA client_golang uses at v0.9.4 (https://github.com/prometheus/client_golang/blob/v0.9.4/go.mod#L9)

@liggitt
Copy link
Member

liggitt commented Sep 23, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit e519736 into kubernetes:master Sep 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 23, 2019
@draveness draveness deleted the feature/bump-prometheus-common branch September 24, 2019 03:36
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#79261 from draveness/feature/bump-prome…
80d16cd 
…theus-common

feat: bump prometheus common to v0.1.0

Kubernetes-commit: e519736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjmcnaughton mattjmcnaughton mattjmcnaughton left review comments

@liggitt liggitt liggitt left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dims dims

@BenTheElder BenTheElder

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
10 participants
@draveness @cblecker @dims @roycaihw @liggitt @brancz @k8s-ci-robot @fejta-bot @mattjmcnaughton @BenTheElder