Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move e2e node perf test to flaky suite #78548

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Move e2e node perf test to flaky suite #78548

merged 1 commit into from
Jun 1, 2019

Conversation

dashpole
Copy link
Contributor

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
The node perf tests were added a while back, but never passed that I can recall. These tests seem to be very long, and cause the https://k8s-testgrid.appspot.com/sig-node-kubelet#node-kubelet-serial suite to time-out. Move these to the flaky suite while they are worked on so we can get a better signal for stable features that are tested in that suite.

Does this PR introduce a user-facing change?:

NONE

/assign @jiayingz

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 30, 2019
@dashpole
Copy link
Contributor Author

/priority important-soon
/sig node

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 30, 2019
@dashpole
Copy link
Contributor Author

/assign @Random-Liu

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 30, 2019
@k8s-ci-robot k8s-ci-robot requested review from dims and yujuhong May 30, 2019 20:55
@dashpole
Copy link
Contributor Author

/retest

1 similar comment
@dashpole
Copy link
Contributor Author

/retest

@Random-Liu
Copy link
Member

I had a same change a while back. #76799

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2019
@dashpole
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce-big

@dchen1107 dchen1107 added this to the v1.15 milestone May 31, 2019
@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit ed4c1dd into kubernetes:master Jun 1, 2019
@dashpole dashpole deleted the flaky_performance branch June 3, 2019 16:03
@Random-Liu Random-Liu mentioned this pull request Jun 12, 2019
Closed
@roycaihw roycaihw mentioned this pull request Feb 10, 2020
Closed
@alejandrox1 alejandrox1 mentioned this pull request May 21, 2020
Closed
This was referenced Jun 9, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims

@yujuhong yujuhong

Assignees

@Random-Liu Random-Liu

@dchen1107 dchen1107

@jiayingz jiayingz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.
5 participants
@dashpole @Random-Liu @k8s-ci-robot @dchen1107 @jiayingz