Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions: unify webhook conversion error messages #78536

Merged

Conversation

sttts
Copy link
Contributor

@sttts sttts commented May 30, 2019

Before this PR error messages were not suited for users:

error: pizzas.restaurant.programming-kubernetes.info "salami" could not be patched: conversion request failed for &{map[apiVersion:restaurant.programming-kubernetes.info/v1beta1 kind:Pizza metadata:map[creationTimestamp:2019-05-30T14:19:54Z generation:1 name:salami namespace:default uid:b5e86564-aadb-40a3-a235-f94beb38a841] spec:map[toppings:[map[name:tomato quantity:1] map[name:mozzarella quantity:1] map[name:salami quantity:1]]] status:map[]]}, Response: &ConversionReview{Request:&ConversionRequest{UID:a2023e6a-5efa-4013-8abe-6cd0d7e2baa8,DesiredAPIVersion:restaurant.programming-kubernetes.info/v1alpha1,Objects:[{[123 34 97 112 105 86 101 114 115 105 111 110 34 58 34 114 101 115 116 97 117 114 97 110 116 46 112 114 111 103 114 97 109 109 105 110 103 45 107 117 98 101 114 110 101 116 101 115 46 105 110 102 111 47 118 49 98 101 116 97 49 34 44 34 107 105 110 100 34 58 34 80 105 122 122 97 34 44 34 109 101 116 97 100 97 116 97 34 58 123 34 99 114 101 97 116 105 111 110 84 105 109 101 115 116 97 109 112 34 58 34 50 48 49 57 45 48 53 45 51 48 84 49 52 58 49 57 58 53 52 90 34 44 34 103 101 110 101 114 97 116 105 111 110 34 58 49 44 34 110 97 109 101 34 58 34 115 97 108 97 109 105 34 44 34 110 97 109 101 115 112 97 99 101 34 58 34 100 101 102 97 117 108 116 34 44 34 117 105 100 34 58 34 98 53 101 56 54 53 54 52 45 97 97 100 98 45 52 48 97 51 45 97 50 51 53 45 102 57 52 98 101 98 51 56 97 56 52 49 34 125 44 34 115 112 101 99 34 58 123 34 116 111 112 112 105 110 103 115 34 58 91 123 34 110 97 109 101 34 58 34 116 111 109 97 116 111 34 44 34 113 117 97 110 116 105 116 121 34 58 49 125 44 123 34 110 97 109 101 34 58 34 109 111 122 122 97 114 101 108 108 97 34 44 34 113 117 97 110 116 105 116 121 34 58 49 125 44 123 34 110 97 109 101 34 58 34 115 97 108 97 109 105 34 44 34 113 117 97 110 116 105 116 121 34 58 49 125 93 125 44 34 115 116 97 116 117 115 34 58 123 125 125] <nil>}],},Response:&ConversionResponse{UID:a2023e6a-5efa-4013-8abe-6cd0d7e2baa8,ConvertedObjects:[],Result:k8s_io_apimachinery_pkg_apis_meta_v1.Status{ListMeta:ListMeta{SelfLink:,ResourceVersion:,Continue:,RemainingItemCount:nil,},Status:Failure,Message:cannot convert restaurant.programming-kubernetes.info/v1beta1 to restaurant.programming-kubernetes.info/v1alpha1,Reason:,Details:nil,Code:0,},},}

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

@sttts: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 30, 2019
@k8s-ci-robot k8s-ci-robot requested review from enisoc and mbohlool May 30, 2019 17:03
@sttts sttts added this to the v1.15 milestone May 30, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 30, 2019
@sttts sttts added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels May 30, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 30, 2019
@sttts sttts added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 30, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 30, 2019
@sttts sttts added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 30, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 30, 2019
@sttts sttts force-pushed the sttts-crd-conversion-error-message branch from 7471267 to 24a9581 Compare May 30, 2019 17:47
@sttts
Copy link
Contributor Author

sttts commented May 30, 2019

/assign @jpbetz

@sttts
Copy link
Contributor Author

sttts commented May 30, 2019

/retest

@liggitt
Copy link
Member

liggitt commented May 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor Author

sttts commented May 30, 2019

/retest

@liggitt
Copy link
Member

liggitt commented May 30, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit e97514e into kubernetes:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/custom-resources cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants