Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latency metrics for etcd operations #7833

Merged
merged 1 commit into from
May 7, 2015

Conversation

fgrzadkowski
Copy link
Contributor

This adds some metrics listed #1625

@davidopp @wojtek-t

)

func getTypeNamefromObject(obj runtime.Object) string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/from/From/

same below

@mbforbes
Copy link
Contributor

mbforbes commented May 6, 2015

Assigning to @davidopp; didn't rope in many others from #1625 as this is a relatively small PR.

@a-robinson
Copy link
Contributor

/sub - I'm interested in at least being notified of new metrics being added to the master process

@davidopp
Copy link
Member

davidopp commented May 7, 2015

LGTM

@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2015
wojtek-t added a commit that referenced this pull request May 7, 2015
Add latency metrics for etcd operations
@wojtek-t wojtek-t merged commit 9ab1679 into kubernetes:master May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants