-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS: expose 53/TCP #7822
DNS: expose 53/TCP #7822
Conversation
@cjcullen of course feel free to swap around |
e2e is hard - the only tool I know that can do TCP lookups is dig, and busybox !has dig. will keep thinking about this. In the mean time, manually tested. |
LGTM |
(To @vishh as he's already looked now.) I'll merge on green tomorrow—squash maybe? |
Give me a bit to figure out e2e. I can't figure out how to reproducibly On Tue, May 5, 2015 at 9:21 PM, Maxwell Forbes notifications@github.com
|
Mmm... wish I knew more about *nix tooling ... @zmerlynn does, I think—thoughts? |
The dig source code is the ISC bind distribution and does not have a On Tue, May 5, 2015 at 11:33 PM, Maxwell Forbes notifications@github.com
|
When I had to do this in bring up scripts on our system, I was left with
|
Added e2e, PTAL |
Thanks for the e2e Tim. LGTM |
Finish v1beta3 conversion, too.
Fixes #7474
@vishh or @cjcullen
Will add e2e coverage of this if I can figure it out.