-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ISCSI to PV structs #7734
Conversation
LGTM |
LGTM |
Travis came back green. One of the tests flaked last time. |
According the shippable, the build is failing. @markturansky can you take a look ? |
I have no insight into the shippable build. Can you tell me what went wrong? |
|
ah, i see. conversion generation fun and mixup with the NFS branch. |
Rebased and regenerated conversions. Waiting for green. |
Shippable still fails:
|
@ArtfulCoder I can run test-cmd locally just fine on both OS X and Fedora 20. I don't see an error in the text above that looks related to ISCSI conversion. |
I just kicked it again after passing all tests locally. |
@ArtfulCoder All green but for Shippable. |
will do one last run of shippable. its failing for go 1.3 and v1beta3, passes for go 1.4 v1beta1.. |
@markturansky can you check if there is a real issue here ? (go 1.3, v1beta3 combo) |
@ArtfulCoder any suggestions for recreating this? My F20 box is running Go 1.3.1 and all tests pass for me. |
@thockin similar to #7564, this adds ISCSI to PV.