Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum docker version to 1.13.1 in kubeadm #77051

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Bump minimum docker version to 1.13.1 in kubeadm #77051

merged 1 commit into from
Apr 26, 2019

Conversation

chenzhiwei
Copy link
Contributor

@chenzhiwei chenzhiwei commented Apr 25, 2019 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump minimum docker version to 1.13.1, as Kubernetes bumped in #72831

Which issue(s) this PR fixes:

Related to: #72831

Special notes for your reviewer:

/area kubeadm
sig/cluster-lifecycle

/assign @yagonobre
/assign @neolit123

Does this PR introduce a user-facing change?:

kubeadm: bump the minimum supported Docker version to 1.13.1

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 25, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @chenzhiwei. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 25, 2019
neolit123
neolit123 reviewed Apr 25, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
/approve
/ok-to-test
/priority important-longterm

@chenzhiwei thanks
please add a release note instead of NONE
kubeadm: bump the minimum supported Docker version to 1.13.1

@kubernetes/sig-cluster-lifecycle-pr-reviews
this is something i requested because the core no longer supports <1.13 and kubeadm is behind.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenzhiwei, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 25, 2019
@chenzhiwei
Copy link
Contributor Author

@neolit123 Updated with the release note, thanks.

@chenzhiwei chenzhiwei force-pushed the bump-docker-version branch from d742b59 to d4aaacf Compare April 25, 2019 13:58
@neolit123
Copy link
Member

/retest

@chenzhiwei
Copy link
Contributor Author

/assign @rosti

Could you review this PR?

neolit123
neolit123 reviewed Apr 26, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging on lazy consensus.
the dockershim has 1.13 as the minimum already.
/lgtm
/aprove
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 26, 2019
@neolit123 neolit123 mentioned this pull request Apr 26, 2019
Merged
@k8s-ci-robot k8s-ci-robot merged commit 59a8682 into kubernetes:master Apr 26, 2019
@naveensriram naveensriram mentioned this pull request Jul 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@neolit123 neolit123

@rosti rosti

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenzhiwei @k8s-ci-robot @neolit123 @rosti @yagonobre