AWS: Change apiserver to listen on 443 directly, not through nginx #7678
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirrors changes in GCE. I think the same changes will be needed for vagrant.
|
Fixes #7395. |
|
Thanks @roberthbailey - I had missed that issue. Perhaps we should have tags for platform-specific issues (e.g. platform/aws platform/vagrant platform/gce)? |
|
LGTM (sorry for the slow review). |
roberthbailey
added a commit
that referenced
this pull request
May 4, 2015
AWS: Change apiserver to listen on 443 directly, not through nginx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors changes in GCE. I think the same changes will be needed for vagrant.
I think this fixes the problem described in #7622, but only for AWS (not for vagrant). @derekwaynecarr: the changes aren't too bad (trivial, except that you have to make sure you have ca.crt & basic_auth.csv). A simpler (but shorter-term) fix would be just to change the master port for kube-proxy to 6443, just like we currently do for kubelet.