Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libvirt provider for vagrant #7617

Merged

Conversation

pronix
Copy link
Contributor

@pronix pronix commented May 1, 2015

additional way to avoid virtualbox and speedup vm.

@derekwaynecarr
Copy link
Member

This is cool. I will look to try this out tomorrow time permitting. Does this allow for parallel boot of the boxes? Can you clarify which version of vagrant-libvirt plugin you tested this on and on what host OS?

@pronix
Copy link
Contributor Author

pronix commented May 5, 2015

hello
yes, allow parallel, vagrant 1.7.2, vagrant-libvirt 0.0.26, os - fedora21

config.vm.provider :libvirt do |v, override|
setvmboxandurl(override, :libvirt)
v.memory = vm_mem
v,cpus = $vm_cpus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be a dot rather than comma, or?..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.fixed.

@derekwaynecarr
Copy link
Member

Can you squash the commits?

Are you able to assist with any libvirt specific issues in the future?

@derekwaynecarr
Copy link
Member

Can you update the document here to include information on the prerequisite versions of plugins, etc.?

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/getting-started-guides/vagrant.md

@pronix
Copy link
Contributor Author

pronix commented May 12, 2015

Hello.
Today will squashed and added information to docs.
Thanks
On 12 May 2015 16:36, "Derek Carr" notifications@github.com wrote:

Can you update the document here to include information on the
prerequisite versions of plugins, etc.?

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/getting-started-guides/vagrant.md


Reply to this email directly or view it on GitHub
#7617 (comment)
.

@pronix pronix force-pushed the add_libvirt_vagrant_provider branch from 560ce79 to a3a4ef7 Compare May 14, 2015 08:33
typo. thanks @Fodoj
add short desc and link to docs
@pronix pronix force-pushed the add_libvirt_vagrant_provider branch from a3a4ef7 to 3519e83 Compare May 14, 2015 08:38
@pronix
Copy link
Contributor Author

pronix commented May 14, 2015

hello
squashed, added short description and link to docs.
And sure I will support with any question

@derekwaynecarr
Copy link
Member

LGTM, thanks a lot for your contribution.

derekwaynecarr added a commit that referenced this pull request May 18, 2015
@derekwaynecarr derekwaynecarr merged commit 4753021 into kubernetes:master May 18, 2015
@pronix pronix deleted the add_libvirt_vagrant_provider branch May 18, 2015 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants