Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.13: Fix AWS driver fails to provision specified fsType #75943

Merged
merged 1 commit into from
Apr 5, 2019
Merged

1.13: Fix AWS driver fails to provision specified fsType #75943

merged 1 commit into from
Apr 5, 2019

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Apr 1, 2019 •
edited
Loading

What type of PR is this?
/kind bug
/sig storage
/sig aws

What this PR does / why we need it:
This is manual cherry pick of commit 732eb69 from #70823 which is too big to backport (it expects storage e2e test framework from 1.14).

Which issue(s) this PR fixes:
Fixes #75941

Does this PR introduce a user-facing change?:

Fixed parsing of fsType in AWS StorageClass parameters

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/aws needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2019
@jsafrane jsafrane changed the title Fix AWS driver fails to provision specified fsType 1.13: Fix AWS driver fails to provision specified fsType Apr 1, 2019
@jsafrane jsafrane mentioned this pull request Apr 1, 2019
Closed
@gnufied
Copy link
Member

gnufied commented Apr 2, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2019
@jsafrane jsafrane mentioned this pull request Apr 3, 2019
Merged
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1a85126 into kubernetes:release-1.13 Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@gnufied gnufied

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsafrane @k8s-ci-robot @gnufied @tpepper @mkimuram