Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump fsnotify vendor to 1.4.7 #75376

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Bump fsnotify vendor to 1.4.7 #75376

merged 1 commit into from
Mar 20, 2019

Conversation

cpuguy83
Copy link
Contributor

@cpuguy83 cpuguy83 commented Mar 14, 2019 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes a number of issues including deadlocks and leaking file
descriptors due to not using O_CLOEXEC

Which issue(s) this PR fixes:

Special notes for your reviewer:

There are other fixes in fsnotify for O_CLOEXEC on master, but there is no release yet.

Does this PR introduce a user-facing change?:

Fix some potential deadlocks and file descriptor leaking for inotify watches.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 14, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @cpuguy83. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 14, 2019
@k8s-ci-robot k8s-ci-robot requested review from jbeda and thockin March 14, 2019 18:11
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2019
@cpuguy83
Copy link
Contributor Author

/assign cblecker

@cpuguy83
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 14, 2019
@feiskyer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 15, 2019
@feiskyer
Copy link
Member

@cpuguy83 Could you add a release note? I think it should be cherry picked to 1.12 and 1.13.

feiskyer
feiskyer reviewed Mar 15, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 15, 2019
@cpuguy83
Bump fsnotify vendor to 1.4.7
4482e3f 
This fixes a number of issues including deadlocks and leaking file
descriptors due to not using `O_CLOEXEC`
@cpuguy83 cpuguy83 force-pushed the bump_fsnotify_vendor branch from c29e9c5 to 4482e3f Compare March 15, 2019 19:03
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2019
@cpuguy83
Copy link
Contributor Author

/retest pull-kubernetes-kubemark-e2e-gce-big

@feiskyer
Copy link
Member

/retest
/lgtm
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 16, 2019
@dims
Copy link
Member

dims commented Mar 18, 2019

/test pull-kubernetes-cross

@cblecker
Copy link
Member

/retest
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cpuguy83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit ac6b1a1 into kubernetes:master Mar 20, 2019
@cpuguy83 cpuguy83 deleted the bump_fsnotify_vendor branch March 20, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@jbeda jbeda Awaiting requested review from jbeda

@thockin thockin Awaiting requested review from thockin

Assignees

@feiskyer feiskyer

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cpuguy83 @k8s-ci-robot @feiskyer @dims @cblecker