Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label on UpdateContainerResources operation #75278

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Fix label on UpdateContainerResources operation #75278

merged 1 commit into from
Apr 12, 2019

Conversation

nessex
Copy link
Contributor

@nessex nessex commented Mar 12, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This fixes the label on exported metrics to do with the UpdateContainerResources operation. They are currently recorded as container_status, but there is already a ContainerStatus operation using that label as well. Note that this uses update_container instead of update_container_resources as that is what the corresponding docker instrumented operation reports.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

UpdateContainerResources is no longer recorded as a `container_status` operation. It now uses the label `update_container`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @nessex. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 12, 2019
@k8s-ci-robot k8s-ci-robot requested review from dims and Random-Liu March 12, 2019 05:29
@nessex
Copy link
Contributor Author

nessex commented Mar 14, 2019

/assign @dchen1107

@nessex
Copy link
Contributor Author

nessex commented Mar 27, 2019

/unassign dchen1107

@nessex
Copy link
Contributor Author

nessex commented Mar 27, 2019

/assign Random-Liu

@nessex
Copy link
Contributor Author

nessex commented Apr 10, 2019

/auto-cc

@k8s-ci-robot k8s-ci-robot requested review from dashpole and tmrts April 10, 2019 09:36
@dims
Copy link
Member

dims commented Apr 11, 2019

/ok-to-test
/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 11, 2019
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2019
@dims
Copy link
Member

dims commented Apr 11, 2019

/assign @yujuhong @derekwaynecarr

@dims
Copy link
Member

dims commented Apr 11, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 11, 2019
@derekwaynecarr
Copy link
Member

looks like a copy/paste bug.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, Nessex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@dims
Copy link
Member

dims commented Apr 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@nessex
Copy link
Contributor Author

nessex commented Apr 12, 2019

Thank you both!
/test pull-kubernetes-kubemark-e2e-gce-big

@nessex
Copy link
Contributor Author

nessex commented Apr 12, 2019

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@nessex
Copy link
Contributor Author

nessex commented Apr 12, 2019

Looks like the test issue is this one: #76490

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 097d585 into kubernetes:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@dashpole dashpole Awaiting requested review from dashpole

@tmrts tmrts Awaiting requested review from tmrts

Assignees

@dims dims

@Random-Liu Random-Liu

@derekwaynecarr derekwaynecarr

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.
8 participants
@nessex @k8s-ci-robot @dims @derekwaynecarr @fejta-bot @Random-Liu @dchen1107 @yujuhong