Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellcheck lint errors in test/images/* scripts #74601

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Fix shellcheck lint errors in test/images/* scripts #74601

merged 3 commits into from
Apr 17, 2019

Conversation

mrbobbytables
Copy link
Member

@mrbobbytables mrbobbytables commented Feb 26, 2019 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Ensures all scripts under test/images/* pass hack/verify-shellcheck.sh
EDIT: Most of the scripts have been updated in other PRs. This is now limited to:

test/images/volume/gluster/run_gluster.sh
test/images/volume/iscsi/create_block.sh
test/images/volume/nfs/run_nfs.sh

Which issue(s) this PR fixes:
Working towards #72956

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/sig testing
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 26, 2019
@k8s-ci-robot k8s-ci-robot requested review from luxas and sttts February 26, 2019 14:18
mrbobbytables
mrbobbytables commented Feb 26, 2019
View reviewed changes
test/images/volume/nfs/run_nfs.sh
@@ -22,21 +22,22 @@ function start()
while getopts "G:" opt; do
case ${opt} in
G) gid=${OPTARG};;
*):;;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SC2220 - "Invalid flags are not handled. Add a *) case."

This just adds a default 'true' case that does nothing, alternative could be to just disable the check.

@mrbobbytables mrbobbytables mentioned this pull request Feb 26, 2019
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2019
@mrbobbytables mrbobbytables force-pushed the fix-test-image-shellcheck branch 3 times, most recently from 62170aa to a780af4 Compare March 1, 2019 18:28
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2019
@mrbobbytables
Copy link
Member Author

/retest

@mrbobbytables mrbobbytables force-pushed the fix-test-image-shellcheck branch from a780af4 to 1ac64b9 Compare March 1, 2019 21:54
@soggiest
Copy link

soggiest commented Mar 7, 2019

Hello! Issue #72956 looks like it's waiting on this issue to close as part the work it defines. 1.14 code freeze is coming up in the next couple days. Can we get some reviews @luxas @sttts and get this merged?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2019
@mrbobbytables mrbobbytables force-pushed the fix-test-image-shellcheck branch from 1ac64b9 to c3e1663 Compare April 11, 2019 17:22
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 11, 2019
@mrbobbytables
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2019
@mrbobbytables mrbobbytables force-pushed the fix-test-image-shellcheck branch from c3e1663 to 74c556a Compare April 14, 2019 02:20
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2019
@mrbobbytables
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2019
@mrbobbytables mrbobbytables force-pushed the fix-test-image-shellcheck branch from 74c556a to ce1159c Compare April 14, 2019 21:45
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2019
@mrbobbytables
Copy link
Member Author

/retest

@mrbobbytables mrbobbytables force-pushed the fix-test-image-shellcheck branch from ce1159c to 5518def Compare April 16, 2019 00:02
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 16, 2019 •
edited
Loading

@mrbobbytables: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-godeps ed43fd33452919d015bacbb52587a5458ca530f6 link /test pull-kubernetes-godeps

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mrbobbytables
Copy link
Member Author

/retest

@k-toyoda-pi
Copy link
Contributor

Hello, I checked your changes. I think your changes are appropriate.

@sttts
Copy link
Contributor

sttts commented Apr 17, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit c3bec0b into kubernetes:master Apr 17, 2019
@mrbobbytables mrbobbytables deleted the fix-test-image-shellcheck branch April 21, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas Awaiting requested review from luxas

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrbobbytables @soggiest @k8s-ci-robot @k-toyoda-pi @sttts