-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up self-set node labels #74424
Clean up self-set node labels #74424
Conversation
@liggitt: GitHub didn't allow me to request PR reviews from the following users: dekkagaijin. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @MrHohn |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7528540
to
8e99042
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for kube-proxy and ip-masq-agent
8e99042
to
7f20205
Compare
/retest |
…google.com/metadata-proxy-ready
…bernetes.io/kube-proxy-ds-ready
…bernetes.io/masq-agent-ds-ready
7f20205
to
e1db43a
Compare
/lgtm |
/hold would like @dekkagaijin to weigh in on the metadata proxy change |
@dekkagaijin please review per @liggitt's comment above. Code freeze for 1.14 is in 3 days, this will need to be merged within the week. |
I have precious little knowledge of the metadata proxy stuff. All of these make me want to hurt myself. Thanks for cleaning up. Do we have a plan as to when we can actually get rid of them? I know proxy daemonset work stalled.. |
@mikedanese for metdata viz, too |
/lgtm |
@dekkagaijin: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm
on Jake's behalf
…On Tue, Mar 5, 2019 at 11:36 AM Kubernetes Prow Robot ***@***.***> wrote:
@dekkagaijin: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
/hold cancel
we will need to keep selectors long term for the things that legitimately may not want to run on every node (masq-agent and metadata-proxy) I don't know if there were blockers to kube-proxy progressing to run as a DS or if that work just got preempted |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Starts to clean up self-set kubelet labels under k8s.io prefixes:
beta.kubernetes.io/metadata-proxy-ready
label to acloud.google.com/metadata-proxy-ready
label by adding the label to new nodes and labeling existing nodes on upgradebeta.kubernetes.io/kube-proxy-ds-ready
label to anode.kubernetes.io/kube-proxy-ds-ready
label by adding the label to new nodes and labeling existing nodes on upgradebeta.kubernetes.io/masq-agent-ds-ready
label to anode.kubernetes.io/masq-agent-ds-ready
label by adding the label to new nodes and labeling existing nodes on upgradeThis is related to https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/0000-20170814-bounding-self-labeling-kubelets.md#implementation-timeline
Does this PR introduce a user-facing change?:
/cc @piosz
for fluentd cleanup
/cc @dekkagaijin
for metadata proxy label
/sig cluster-lifecycle
/sig gcp