Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to container manager and internal container lifecycle to accommodate TopologyManager #74357

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Updates to container manager and internal container lifecycle to accommodate TopologyManager #74357

merged 1 commit into from
Aug 1, 2019

Conversation

lmdaly
Copy link
Contributor

@lmdaly lmdaly commented Feb 21, 2019

What this PR does / why we need it:
Adding support for Topology Manager to Container Manager and Internal container lifecycle
Topology Manager based merged design proposal here: kubernetes/community#1680
Issue for tracking PRs: #72828
What type of PR is this?

/kind feature

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @lmdaly. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 21, 2019
@lmdaly
Copy link
Contributor Author

lmdaly commented Feb 21, 2019

/cc @ConnorDoyle @balajismaniam @nolancon

@k8s-ci-robot
Copy link
Contributor

@lmdaly: GitHub didn't allow me to request PR reviews from the following users: nolancon.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ConnorDoyle @balajismaniam @nolancon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lmdaly lmdaly mentioned this pull request Feb 21, 2019
Closed
@spiffxp
Copy link
Member

spiffxp commented Feb 24, 2019

/hold
ref: kubernetes/enhancements#693 (comment)

/ok-to-test

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2019
@klueska klueska mentioned this pull request May 28, 2019
Merged
klueska
klueska approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@klueska klueska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending previous PRs are merged.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2019
@lmdaly lmdaly force-pushed the topology-manager-container-manager branch from 26c0201 to acf528d Compare May 30, 2019 13:40
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2019
@lmdaly
Copy link
Contributor Author

lmdaly commented May 31, 2019

PR Depends on:
#73580
#74411

@sjenning
Copy link
Contributor

/kind feature
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 17, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019
@sjenning
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2019
@sjenning
Copy link
Contributor

ah yes, we are out of pkg/kubelet/cm now. my powers are useless here!
/assign @dchen1107 @derekwaynecarr

@moshe010 moshe010 mentioned this pull request Jul 23, 2019
Merged
@lmdaly
Updates to container manager and internal container lifecycle to acco…
9f0081c 
…mmodate Topology Manager

Co-authored-by: Conor Nolan <conor.nolan@intel.com>
@lmdaly lmdaly force-pushed the topology-manager-container-manager branch from 64db822 to 14d9510 Compare July 24, 2019 13:19
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@lmdaly
Copy link
Contributor Author

lmdaly commented Jul 24, 2019

/retest

@klueska
Copy link
Contributor

klueska commented Jul 24, 2019

Looks like it needs a rebase on the newest master before retesting

@lmdaly lmdaly force-pushed the topology-manager-container-manager branch from 14d9510 to 9f0081c Compare July 24, 2019 14:04
This was referenced Jul 25, 2019
Merged
Merged
@klueska
Copy link
Contributor

klueska commented Jul 29, 2019

/lgtm
/assign yujuhong

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2019
@derekwaynecarr
Copy link
Member

taking a look now per sig-node discussion.
/assign

derekwaynecarr
derekwaynecarr approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

in a follow-on please remove the use of Experimental prefix, it ends up being a pain when they no longer are experimental to clean the naming up later.

pkg/kubelet/cm/container_manager.go
@@ -127,6 +131,7 @@ type NodeConfig struct {
ExperimentalPodPidsLimit int64
EnforceCPULimits bool
CPUCFSQuotaPeriod time.Duration
ExperimentalTopologyManagerPolicy string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we will plan to move this out of experimental in the future, is it better if we just call this TopologyManagerPolicy to avoid a future rename?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

pkg/kubelet/cm/container_manager_linux.go
return nil, err
}

klog.Infof("[topologymanager] Initilizing Topology Manager with %s policy", nodeConfig.ExperimentalTopologyManagerPolicy)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "Initializing"

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, lmdaly, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 93e6fb3 into kubernetes:master Aug 1, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 1, 2019
@lmdaly lmdaly mentioned this pull request Aug 26, 2019
Closed
6 tasks
@nolancon nolancon mentioned this pull request Sep 3, 2019
Closed
@pacoxu pacoxu mentioned this pull request Jan 18, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning sjenning left review comments

@tedyu tedyu tedyu left review comments

@klueska klueska klueska approved these changes

@derekwaynecarr derekwaynecarr derekwaynecarr approved these changes

@tmrts tmrts Awaiting requested review from tmrts

@ConnorDoyle ConnorDoyle Awaiting requested review from ConnorDoyle

@balajismaniam balajismaniam Awaiting requested review from balajismaniam

Assignees

@klueska klueska

@sjenning sjenning

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
9 participants
@lmdaly @k8s-ci-robot @spiffxp @sjenning @klueska @derekwaynecarr @tedyu @dchen1107 @yujuhong