Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make missing-directory errors non fatal #73542

Merged
merged 1 commit into from
Feb 1, 2019
Merged

make missing-directory errors non fatal #73542

merged 1 commit into from
Feb 1, 2019

Conversation

juanvallejo
Copy link
Contributor

Fixes kubernetes/kubectl#574

/kind cleanup
/sig cli

Missing directories listed in a user's PATH are no longer considered errors and are instead logged by the "kubectl plugin list" command when listing available plugins.

cc @soltysh @ahmetb

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 30, 2019
@juanvallejo juanvallejo mentioned this pull request Jan 30, 2019
Closed
@ahmetb
Copy link
Member

ahmetb commented Jan 30, 2019

LGTM assuming -v=3 doesn't show to users by default.

@juanvallejo
Copy link
Contributor Author

LGTM assuming -v=3 doesn't show to users by default.

Nope, you explicitly have to pass --v 3 to receive this message

@juanvallejo juanvallejo force-pushed the jvallejo/log-missing-dir-errors branch from 43f3bf2 to de01516 Compare January 30, 2019 20:45
soltysh
soltysh approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit ad58fb1 into kubernetes:master Feb 1, 2019
@juanvallejo juanvallejo deleted the jvallejo/log-missing-dir-errors branch February 1, 2019 14:57
@krzyzacy krzyzacy mentioned this pull request Feb 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@seans3 seans3 Awaiting requested review from seans3

@shiywang shiywang Awaiting requested review from shiywang

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanvallejo @ahmetb @k8s-ci-robot @soltysh