VolumeDevices validation and tests #72375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/assign @liggitt |
k8s-ci-robot
added
the
sig/apps
21 tasks
|
/test pull-kubernetes-verify |
liggitt
reviewed
Dec 27, 2018
pkg/api/pod/util.go
Outdated
| @@ -337,25 +337,16 @@ func dropDisabledProcMountField(podSpec, oldPodSpec *api.PodSpec) { | |||
| } | |||
| } | |||
|
|
|||
| // dropDisabledVolumeDevicesAlphaFields removes disabled fields from []VolumeDevice. | |||
| // dropDisabledVolumeDevicesAlphaFields removes disabled fields from []VolumeDevice if it has not been already populated. | |||
| // This should be called from PrepareForCreate/PrepareForUpdate for all resources containing a VolumeDevice | |||
| func dropDisabledVolumeDevicesAlphaFields(podSpec, oldPodSpec *api.PodSpec) { | |||
There was a problem hiding this comment.
rename to dropDisabledVolumeDevicesFields
pkg/api/pod/util_test.go
Outdated
| @@ -455,17 +527,17 @@ func TestDropRuntimeClass(t *testing.T) { | |||
| { | |||
| description: "pod Without RuntimeClassName", | |||
| hasPodRuntimeClassName: false, | |||
| pod: podWithoutRuntimeClass, | |||
| pod: podWithoutRuntimeClass, | |||
|
a couple nits, lgtm otherwise |
|
/retest |
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sbezverk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Serguei Bezverkhi sbezverk@cisco.com
See for reference issue: #72169
/sig api-machinery
/sig storage
/kind cleanup
/release-note-none