Move RunRC, DeleteRC, and ListPods into the utility module and refactor #7235
Conversation
to be support functions kubernetes#7234
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| podsLaunched += n | ||
| glog.Info("Launched %v pods so far...", podsLaunched) | ||
| Logf("Launched %v pods so far...", podsLaunched) |
There was a problem hiding this comment.
Just curious: why do you replace it? The "glog" format seems to have more information.
There was a problem hiding this comment.
We want all logging to be done through ginkgo's logging facilities. That's why Logf was written.
There was a problem hiding this comment.
I see - that's why we are using a different logging in the code itself than in e2e test, right?
There was a problem hiding this comment.
Correct. Ginkgo allows parallelizing tests and other features and using its logging facility ensures the logs stay with the test and get rolled up in reports generated from ginkgo logs.
|
LGTM |
wojtek-t
added
the
lgtm
Move RunRC, DeleteRC, and ListPods into the utility module and refactor
ghost
merged commit 
to be support functions #7234