-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Juju charms to Kubernetes #7195
Conversation
Implemented a feature of kube-down Corrected a bug on bootstrap of Juju environment.
Change cadvisor port and point kubelet to find it
- use absolute path for kube_root (fixes JUJU_REPOSITORY directory creation issue) - shortcircuit status polling (for rerunning kubeup) - more granular polling iterations
Script and bundle tweaks
- Formatted for consistency - Used different variables for juju directory
…harms Resolved conflicts in: cluster/juju/util.sh
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
@whitmo needs to state on this PR that he intended for his commits to be on this PR, otherwise, our CLA robot is confused. |
@erictune Is stating here good enough? I also filled in the personal CLA from my user account (and will make sure further commits come from my canonical address). |
LGTM. I don't know why CLAbot is not happy, but seems like this PR is covered. |
automated build says it doesn't like your boilerplate. $ ./hack/verify-boilerplate.sh I think all the shell scripts need to have Google copyright at the top. |
@erictune Sorry about that, those were scripts we no longer use so I removed them. |
Add the Juju charms to Kubernetes
thanks for the contribution and for your patience! |
This is a follow up to the original Juju pull request:
#5414
In accordance with @erictune's suggestion we are adding the charms and a bundle to keep in better sync with the kubernetes project.
cluster/kube-up.sh
will deploy the local charms and the bundle from the kubernetes repository and stand up a cluster.We have done a lot of work to update the cluster/juju/util.sh to the v0.15.0 release that changed the API and a lot of changes:
cluster/juju/charms
directory.cluster/juju/bundles
directory.cluster/juju/util.sh
script uses the bundle to deploy the charms from the kubernetes repository.We are still seeing some issues with the
validate-cluster.sh
script ('Error: no resource "cs" has been defined') but I don't think that is related to our changes in this pull request. Manual testing shows that we can create objects in the kubernetes cluster.