Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change kube2sky to use token-system-dns secret, point at https endpoint ... #7154

Merged
merged 1 commit into from
Apr 22, 2015
Merged

Change kube2sky to use token-system-dns secret, point at https endpoint ... #7154

merged 1 commit into from
Apr 22, 2015
+38 −14

Conversation

cjcullen
Copy link
Member

...(instead of kubernetes-ro service).

@cjcullen cjcullen force-pushed the readonly branch 3 times, most recently from 1310e8c to 4828f18 Compare April 22, 2015 05:59
@cjcullen
Copy link
Member Author

After I get an LGTM and a clean e2e, I'll rebuild the kube2sky:1.2 image and push before merging.

thockin
thockin reviewed Apr 22, 2015
View reviewed changes
cluster/addons/dns/skydns-rc.yaml.in
source:
secret:
target:
kind: Secret
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmorie have we fixed or disproved the Secret idempotency problem?

@thockin
Copy link
Member

thockin commented Apr 22, 2015

LGTM but question to @pmorie re: secrets

kube2sky needs a near-total overhaul, but that should not stop this PR.

@fabioy fabioy self-assigned this Apr 22, 2015
@cjcullen
Copy link
Member Author

E2Es are green except the load balancer test (I haven't fetched/rebased since last night when LBs were broken).

roberthbailey added a commit that referenced this pull request Apr 22, 2015
@roberthbailey
Merge pull request #7154 from cjcullen/readonly
35a18e3 
Change kube2sky to use token-system-dns secret, point at https endpoint ...
@roberthbailey roberthbailey merged commit 35a18e3 into kubernetes:master Apr 22, 2015
@cjcullen cjcullen mentioned this pull request Apr 22, 2015
Closed
@fabioy fabioy mentioned this pull request Apr 23, 2015
Merged
@ghost ghost mentioned this pull request Apr 28, 2015
Closed
@ghost
Copy link

ghost commented Apr 28, 2015

This merge appears to have significantly increased flakyness of DNS e2e tests (see #7453 for details). Broken cluster DNS in turn causes a few other e2e tests which rely on DNS to fail.

I'm going to test that a rollback improves things, and then do it.

@cjcullen
Copy link
Member Author

This PR had already been rolled back due to a conflict with another PR. You are probably looking for #7275. I've put together #7461 to roll-back the version of kube2sky to the non-flaky one.

@cjcullen cjcullen mentioned this pull request Apr 29, 2015
Merged
@jimjh
Copy link

jimjh commented May 5, 2015

I ran into some problems with the token-system-dns (see #7359), which I worked around by creating an empty secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjcullen @thockin @jimjh @pmorie @roberthbailey @googlebot @fabioy