Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified syntax doc on --watch-cache-sizes #70959

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Clarified syntax doc on --watch-cache-sizes #70959

merged 1 commit into from
Nov 30, 2018
+4 −3

Conversation

MikeSpreitzer
Copy link
Member

Noted that group must be omitted for resources of apiVersion v1 (the
legacy core API) and included for others.

Fixes #65393

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #65393

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@MikeSpreitzer
Clarified syntax doc on --watch-cache-sizes
fc20359 
Noted that group must be omitted for resources of apiVersion v1 (the
legacy core API) and included for others.

Fixes kubernetes#65393
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 12, 2018
@MikeSpreitzer
Copy link
Member Author

/sig api-machinery

@MikeSpreitzer
Copy link
Member Author

I finally got around to dealing with the review comment on #65397, but it was closed by then.

@fedebongio
Copy link
Contributor

/assign @yliaog

@yliaog
Copy link
Contributor

yliaog commented Nov 12, 2018

why not reopen #65397 ?

@MikeSpreitzer
Copy link
Member Author

I don't know how and I needed a rebase anyway. I thought a new PR would be easier.

@MikeSpreitzer
Copy link
Member Author

@yliaog

@yliaog
Copy link
Contributor

yliaog commented Nov 20, 2018

keep the original pr would keep the comment history. In the prior pr sttts has some comments I copied below.

==========================================================================
What is a core resource? Is that term clear? We might serve a core/v1 API group some day, instead of our legacy API at /api. Maybe just be explicit: is omitted for resources of apiVersion "v1" (the legacy core API) ...

@MikeSpreitzer
Copy link
Member Author

I incorporated the suggestion from @sttts ; you will see the latest PR reads as he suggested.

@yliaog
Copy link
Contributor

yliaog commented Nov 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2018
@yliaog
Copy link
Contributor

yliaog commented Nov 20, 2018

thanks for the pr.

@MikeSpreitzer
Copy link
Member Author

What does it take to get this into a milestone?

@yliaog
Copy link
Contributor

yliaog commented Nov 20, 2018

https://prow.k8s.io/command-help has the command for adding milestone label

@MikeSpreitzer
Copy link
Member Author

@yliaog : it is not I who applies the milestone. Who applies the milestone, and how do I draw their attention to this PR?

@yliaog
Copy link
Contributor

yliaog commented Nov 21, 2018

i think 1.13 release team could apply the milestone label.

@MikeSpreitzer
Copy link
Member Author

MikeSpreitzer commented Nov 21, 2018 •
edited
Loading

@yliaog : how do I discover who is on the release 1.13 team and/or draw their attention to this PR?

@yliaog
Copy link
Contributor

yliaog commented Nov 21, 2018

https://github.com/kubernetes/sig-release/blob/master/releases/release-1.13/release_team.md

@MikeSpreitzer
Copy link
Member Author

@dougm

dougm
dougm reviewed Nov 21, 2018
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , but needs a milestone maintainer to approve (https://github.com/orgs/kubernetes/teams/kubernetes-milestone-maintainers/members)

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Nov 21, 2018 •
edited
Loading

/approve
/priority important-soon

will get this in when master reopens, only release-blocking PRs are intended to merge during freeze

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, MikeSpreitzer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit a08d89c into kubernetes:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm left review comments

@dims dims Awaiting requested review from dims

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@liggitt liggitt

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flag help for --watch-cache-sizes is wrong about group being optional
7 participants
@MikeSpreitzer @fedebongio @yliaog @liggitt @k8s-ci-robot @fejta-bot @dougm