Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate Kubelet plugin registration/watcher to GA #70559

Merged
merged 3 commits into from
Nov 15, 2018
Merged

Graduate Kubelet plugin registration/watcher to GA #70559

merged 3 commits into from
Nov 15, 2018

Conversation

vladimirvivien
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR contains code changes necessary to graduate the Kubelet Plugin Watcher registration mechanism from Beta to GA

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #70484

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

The Kubelet plugin registration mechanism used by device plugins and CSI plugins is now GA

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 1, 2018
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 1, 2018
@vladimirvivien
Copy link
Member Author

/sig node

cc @RenaudWasTaken

@vladimirvivien
Copy link
Member Author

/retest

1 similar comment
@vladimirvivien
Copy link
Member Author

/retest

@vladimirvivien vladimirvivien mentioned this pull request Nov 2, 2018
Closed
6 tasks
@vladimirvivien vladimirvivien changed the title Kubelet Plugin Watcher - Changes to graduate to GA Graduate Kubelet plugin registration/watcher to GA Nov 2, 2018
@vladimirvivien
Copy link
Member Author

@tallclair PTAL

RenaudWasTaken
RenaudWasTaken approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@RenaudWasTaken RenaudWasTaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Though I'm not sure why the Kubelet struct needed to be reformated?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2018
@vladimirvivien
Copy link
Member Author

@RenaudWasTaken thanks for review, not sure why my editor reformatted code after I updated kubelet to point to v1 package. Will take a look. Thanks.

@vladimirvivien
Copy link
Member Author

@vishh PTAL. Looking for approval for 1.13.

@vishh
Copy link
Contributor

vishh commented Nov 5, 2018

Hmm.. Was the switch from alpha->GA discussed early on? What makes us believe that the existing API & behavior is what we'd like to maintain for at-least a year from now?

@msau42 msau42 mentioned this pull request Nov 6, 2018
Closed
@vladimirvivien
Copy link
Member Author

@vishh Hi. This is to go from Beta -> GA. This feature has been in used for a while now. The reference to beta packages were not updated in last previous release. To answer your other questions: this API has been in used by may CSI drivers (https://kubernetes-csi.github.io/docs/Drivers.html). As CSI moves to GA this quarter, we feel this is one of the other API that could go GA as well.

cc @RenaudWasTaken

@saad-ali
Copy link
Member

saad-ali commented Nov 8, 2018

What makes us believe that the existing API & behavior is what we'd like to maintain for at-least a year from now?

This feature defines how CSI drivers are discovered. GA of this feature is a blocker CSI GA (which we are planning for this 1.13 release). It also means that once CSI goes GA the requirements from CSI for this feature are unlikely to change since CSI it self needs to remain backwards compatible and backwards incompatible changes would break CSI).

The existing API has been sufficient for CSI and we haven't changed it since alpha. The only known use cases that we are currently aware of that may require changing the API is adding windows support -- but that so far seems like it won't require any change or only additive change.

@vishh
Copy link
Contributor

vishh commented Nov 8, 2018

I was misguided by the comment which changed from alpha to GA. After chatting with @msau42 offline, I learned that the API has been put to use in the CSI world for a release now and @saad-ali is stating that the API has been sufficient since alpha. I'm more comfortable with graduating this API now.
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2018
@AishSundar
Copy link
Contributor

/priority important-soon
/milestone v1.13

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 12, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 12, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 12, 2018
@RenaudWasTaken RenaudWasTaken mentioned this pull request Nov 12, 2018
Closed
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 13, 2018
@vladimirvivien
Copy link
Member Author

@vishh Please re-approve. I had to rebase.

@vladimirvivien
Copy link
Member Author

@tallclair PTAL, looking for approval for this feature.

saad-ali
saad-ali approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, vishh, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2018
@RenaudWasTaken
Copy link
Contributor

/lgtm

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@msau42
Copy link
Member

msau42 commented Nov 15, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 843a67b into kubernetes:master Nov 15, 2018
@dims dims mentioned this pull request Nov 15, 2018
Closed
@vladimirvivien vladimirvivien mentioned this pull request Nov 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali approved these changes

@RenaudWasTaken RenaudWasTaken RenaudWasTaken approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@thockin thockin Awaiting requested review from thockin

Assignees

@RenaudWasTaken RenaudWasTaken

@vishh vishh

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

Move Kubelet Plugin Registration Watcher to GA
8 participants
@vladimirvivien @vishh @saad-ali @AishSundar @k8s-ci-robot @RenaudWasTaken @fejta-bot @msau42