Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark optional CSIDriver fields as really optional. #69331

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Mark optional CSIDriver fields as really optional. #69331

merged 1 commit into from
Oct 3, 2018

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Oct 2, 2018

What this PR does / why we need it:
CSIDriver has couple of optional fields which don't have omitempty. See the issue below for error message.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes-csi/driver-registrar#57

Release note:

Fixed CSIDriver API object to allow missing fields.

cc @pohly @davidz627 @verult

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 2, 2018
@jsafrane
Copy link
Member Author

jsafrane commented Oct 2, 2018

/kind bug
/sig storage

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 2, 2018
@jsafrane jsafrane mentioned this pull request Oct 2, 2018
Closed
@davidz627
Copy link
Contributor

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2018
@davidz627
Copy link
Contributor

/lgtm cancel

Are there any other types.go files that need to be updated besides this one?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2018
@jsafrane
Copy link
Member Author

jsafrane commented Oct 3, 2018

Are there any other types.go files that need to be updated besides this one?

Not for CSI. Everything is in staging/src/csi-api/pkg/apis.

@jsafrane jsafrane mentioned this pull request Oct 3, 2018
Closed
@saad-ali
Copy link
Member

saad-ali commented Oct 3, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saad-ali
Copy link
Member

saad-ali commented Oct 3, 2018

Please cherry pick to 1.12 branch

@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 2e0e168 into kubernetes:master Oct 3, 2018
@jsafrane jsafrane mentioned this pull request Oct 3, 2018
Merged
@jsafrane
Copy link
Member Author

jsafrane commented Oct 3, 2018

This PR is probably OK, but should PRs here require API approval? @kubernetes/sig-api-machinery-api-reviews

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 3, 2018
@lavalamp
Copy link
Member

lavalamp commented Oct 3, 2018

Yes, it should have required API review (but I also think it is fine). I thought @liggitt had set that up with a fancy OWNERs file, did something get moved?

k8s-ci-robot added a commit that referenced this pull request Oct 4, 2018
@k8s-ci-robot
Merge pull request #69393 from jsafrane/automated-cherry-pick-of-#693…
50285c4 
…31-upstream-release-1.12

Automated cherry pick of #69331: Mark optional fields as really optional.
@jennybuckley
Copy link

/cc @cheftako

@k8s-ci-robot k8s-ci-robot requested a review from cheftako October 4, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mikedanese mikedanese Awaiting requested review from mikedanese

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@davidz627 davidz627

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E: "CSI attach test using HostPath driver" fails
6 participants
@jsafrane @davidz627 @saad-ali @k8s-ci-robot @lavalamp @jennybuckley