Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl replace legacyscheme with kubectl scheme in two tests #69172

Merged
merged 1 commit into from
Sep 28, 2018
Merged

kubectl replace legacyscheme with kubectl scheme in two tests #69172

merged 1 commit into from
Sep 28, 2018
+43 −44

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Sep 27, 2018

  • Replace legacyscheme with kubectl scheme in two tests.
  • Consequently the tests use external versions of resources instead of internal versions.
  • Rename import alias to be more consistent.

Helps address:

kubernetes/kubectl#83

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 27, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2018
@seans3
Copy link
Contributor Author

seans3 commented Sep 27, 2018

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 27, 2018
@seans3
Copy link
Contributor Author

seans3 commented Sep 27, 2018

/retest

@seans3
Copy link
Contributor Author

seans3 commented Sep 27, 2018

/assign

@seans3
Copy link
Contributor Author

seans3 commented Sep 27, 2018

/cc @apelisse
/cc @soltysh

soltysh
soltysh approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7c02428 into kubernetes:master Sep 28, 2018
@seans3 seans3 deleted the test-small-fix branch September 29, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@ericchiang ericchiang Awaiting requested review from ericchiang

@mengqiy mengqiy Awaiting requested review from mengqiy

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@soltysh soltysh

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seans3 @k8s-ci-robot @soltysh