Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #68563: fix scheduler crash when Prioritize Map function failed #69135

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Automated cherry pick of #68563: fix scheduler crash when Prioritize Map function failed #69135

merged 1 commit into from
Sep 30, 2018

Conversation

DylanBLE
Copy link
Contributor

Cherry pick of #68563 on release-1.12.

#68563: fix scheduler crash when Prioritize Map function failed

Release note:

Fix scheduler crashes when Prioritize Map function returns error.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2018
@k82cn
Copy link
Member

k82cn commented Sep 27, 2018

/kind bug
/ok-to-test

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 27, 2018
@DylanBLE
Copy link
Contributor Author

/assign @davidopp

@k82cn
Copy link
Member

k82cn commented Sep 27, 2018

/unassign @davidopp

/lgtm

@k8s-ci-robot k8s-ci-robot assigned k82cn and unassigned davidopp Sep 27, 2018
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 27, 2018
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 28, 2018
@nikhita
Copy link
Member

nikhita commented Sep 29, 2018

/check-cla

@nikhita
Copy link
Member

nikhita commented Sep 29, 2018

Not sure what's up with the cla label here. Take two.

/check-cla

@BenTheElder
Copy link
Member

/check-cla
😕

@BenTheElder BenTheElder mentioned this pull request Sep 29, 2018
Closed
@BenTheElder
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Closing this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

/reopen

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Reopening this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Sep 29, 2018
@BenTheElder
Copy link
Member

We don't know why yet but the CLA status on this page is non-existent in the GitHub API. unless that somehow resolves itself, we can maybe have a repo owner manually apply a CLA label.

you can check yourself here if anyone is interested, I cannot find cla/linuxfoundation at all... https://api.github.com/repos/kubernetes/kubernetes/commits/f33c2c11f209fe55de7681d1b238672dfb4548d9/statuses

@DylanBLE
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@DylanBLE: Closing this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DylanBLE
Copy link
Contributor Author

/check-cla

@DylanBLE
Copy link
Contributor Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@DylanBLE: Reopening this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Sep 30, 2018
@DylanBLE
Copy link
Contributor Author

Maybe someone could cherry pick this fix from master branch.

@BenTheElder
Copy link
Member

We probably need to follow up with GitHub if we don't see it resolve or alter the robot... it's showing up in the overall "status" endpoint but not the "statuses" endpoint due to some bug on their end.

search for "linux" in :

https://api.github.com/repos/kubernetes/kubernetes/commits/f33c2c11f209fe55de7681d1b238672dfb4548d9/statuses

vs

https://api.github.com/repos/kubernetes/kubernetes/commits/f33c2c11f209fe55de7681d1b238672dfb4548d9/status

:tableflip:

@BenTheElder
Copy link
Member

If you do git commit --amend on the branch and then don't change anything, then force push that it should force a new commit hash (due to the timestamp changing) which may force the status to update since they're posted against the commit

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 30, 2018
@DylanBLE
Copy link
Contributor Author

@BenTheElder recommit fix the issue...

@BenTheElder
Copy link
Member

re-lgtm-ing
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, DylanBLE, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Member

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot k8s-ci-robot merged commit b6ea286 into kubernetes:release-1.12 Sep 30, 2018
@ravisantoshgudimetla
Copy link
Contributor

Can we cherry-pick to 1.11 as well?

@DylanBLE
Copy link
Contributor Author

@ravisantoshgudimetla
cherry-pick to 1.11 #69618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@BenTheElder BenTheElder

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@DylanBLE @k82cn @nikhita @BenTheElder @k8s-ci-robot @cblecker @ravisantoshgudimetla @feiskyer @davidopp