kubeadm: fix broken Docker 17.xx validation #68906
Merged
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit updated 17.xx -> 18.xx without considering that some systems still use 17.xx. Add handling for 17.0[3,6,9] as validated versions. Also re-format the error message because the version is not validated per maximum basis, but rather based on existing validation.
k8s-ci-robot
added
release-note-none
|
/retest |
timothysc
approved these changes
Sep 21, 2018
There was a problem hiding this comment.
/lgtm
/approve
This fixes my local UT failures, thx @neolit123 !
k8s-ci-robot
added
lgtm
timothysc
added
priority/critical-urgent
|
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
|
/retest |
|
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A previous commit 97c9fa3#diff-04e26ffab72c7e12fbb59ad41ba114ad updated 17.xx -> 18.xx, but some systems still use 17.xx.
Add handling for 17.0[3,6,9] as validated versions.
Also re-format the error message because the version is not validated
per maximum basis, but rather based on existing validation for individual versions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):NONE
Special notes for your reviewer:
NONE
Release note:
release note NONE if we merge now, otherwise it has to be added.
this is not critical priority for 1.12:
/kind bug
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/assign @timothysc