cleanup duplicate assignment logic in scheduler #68875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Huang-Wei
commented
Sep 20, 2018
pkg/scheduler/factory/factory.go
Outdated
| @@ -265,7 +265,6 @@ func NewConfigFactory(args *ConfigFactoryArgs) scheduler.Configurator { | |||
| DeleteFunc: c.deletePDBFromCache, | |||
| }, | |||
| ) | |||
| c.pdbLister = args.PdbInformer.Lister() | |||
There was a problem hiding this comment.
already assigned in L187
Huang-Wei
commented
Sep 20, 2018
| @@ -177,6 +177,7 @@ func NewConfigFactory(args *ConfigFactoryArgs) scheduler.Configurator { | |||
| client: args.Client, | |||
| podLister: schedulerCache, | |||
| podQueue: core.NewSchedulingQueue(), | |||
| nodeLister: args.NodeInformer.Lister(), | |||
There was a problem hiding this comment.
this is not that necessary, but just to keep the same pattern - init all listers in &configFactory{}, then add watch functions afterwards.
|
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
|
/retest |
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
Huang-Wei
force-pushed
the
minor-scheduler-cleanup
branch
from
1549836 to
56fcfc5
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, k82cn, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cleanup duplicate assignment logic.
Release note:
/cleanup
/sig scheduling