kubeadm: Use GetGenericImage for kube-dns #68830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/kubeadm
size/S
k8s-ci-robot
added
kind/cleanup
|
/priority critical-urgent |
k8s-ci-robot
added
the
priority/critical-urgent
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/milestone v1.12 (will defer to @timothysc and others to clear the milestone if not appropriate / or it is too late) |
As kube-dns transitioned to fat manifests, it's no longer required to use arch suffixed images. This change makes use of fat manifests for kube-dns and removes the last few calls to the GetGenericArchImage function, thus removing GetGenericArchImage too. Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
rosti
force-pushed
the
kill-getgenericarchimage
branch
from
5cb05c0 to
68ed2bd
Compare
k8s-ci-robot
added
size/M
|
Forgot to update the actual manifests, fixed now |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dixudx, mkumatag, rosti, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As kube-dns transitioned to fat manifests (in #68430), it's no longer required to use arch
suffixed images. This change makes use of fat manifests for kube-dns and
removes the last few calls to the GetGenericArchImage function, thus removing
GetGenericArchImage too.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):NONE
Special notes for your reviewer:
Since this PR removes GetGenericArchImage, I'm putting it on hold until #59664 get merged. This is needed, because since #66960, etcd is also required to have a fat manifest (which currently it does not).
/hold
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm
/kind cleanup
/assign @fabriziopandini
/assign @timothysc
/assign @dims
/cc @mkumatag
Release note: