kubeadm: include the 'certs renew' sub-command in the CLI #68808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/cluster-lifecycle
neolit123
force-pushed
the
kubeadm-cert-renew
branch
from
fb3f47d to
8b228a9
Compare
k8s-ci-robot
added
size/M
cmd/kubeadm/app/cmd/phases/certs.go
Outdated
| certTree, err := certsphase.GetDefaultCertList().AsMap().CertTree() | ||
| kubeadmutil.CheckErr(err) | ||
|
|
||
| subCmds := []*cobra.Command{allCmd, saCmd, renewCmd} |
There was a problem hiding this comment.
Personally it's more clear to move this line after L125. But it's ok as-is.
There was a problem hiding this comment.
actually this isn't good either.
will revert the change to reduce the noise.
The command seems to be missing in the CLI. Add it as sub-command under 'kubeadm alpha phase certs'.
neolit123
force-pushed
the
kubeadm-cert-renew
branch
from
8b228a9 to
48d52a3
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
timothysc
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: liztio, neolit123, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
timothysc
approved these changes
Sep 19, 2018
|
/assign @smarterclayton for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The new 'renew' command seems to be missing in the CLI.
Add it as sub-command under 'kubeadm alpha phase certs'.
to follow up on these series:
https://github.com/kubernetes/kubernetes/commits/master/cmd/kubeadm/app/cmd/phases/certs/renew.go
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):NONE
Special notes for your reviewer:
NONE
Release note:
/priority critical-urgent
/kind bug
@kubernetes/sig-cluster-lifecycle-pr-reviews
/assign @liztio @timothysc