Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DS tests to set node selectors related annotations on test namespaces to empty. #68793

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fix DS tests to set node selectors related annotations on test namespaces to empty. #68793

merged 1 commit into from
Oct 8, 2018

Conversation

aveshagarwal
Copy link
Member

@aveshagarwal aveshagarwal commented Sep 18, 2018 •
edited by smarterclayton
Loading

Conformance tests have a higher bar than regular e2e tests and should work on as diverse a set of clusters as possible. If the alpha scheduling admission plugin is on to restrict the set of node labels a pod can target is on, scheduling conformance tests fail.

Scheduling conformance tests related to daemonsets should set the annotation that relaxes node selection restrictions, if any are set. This ensures conformance tests can run on a wider array of clusters.

@smarterclayton @sjenning @kubernetes/sig-apps-pr-reviews @kubernetes/sig-scheduling-pr-reviews

@aveshagarwal
Fix DS tests to set their namespaces to empty node selectors
ea3e676 
so that they keep working with PodNodeSelector plugin.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 18, 2018
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Sep 18, 2018
@smarterclayton
Copy link
Contributor

As conformance tests, the scheduler tests need to be extra sensitive to kubernetes clusters that may impose scheduling restrictions. Since PodNodeSelector is in fairly wide use, this change allows those clusters leveraging it to remain compliant without changing the semantics of the test.

@neolit123
Copy link
Member

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 19, 2018
@smarterclayton
Copy link
Contributor

This will need to be back ported to 1.10 at the least, although it's not critical that we deliver pre 1.12 GA

@aveshagarwal aveshagarwal mentioned this pull request Sep 19, 2018
Merged
@smarterclayton
Copy link
Contributor

smarterclayton commented Oct 8, 2018 •
edited
Loading

/lgtm

now that 1.13 is open. Let's back port to 1.10, 1.11, and 1.12 so that the conformance tests tolerate this

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 981a064 into kubernetes:master Oct 8, 2018
@aveshagarwal
Copy link
Member Author

now that 1.13 is open. Let's back port to 1.10, 1.11, and 1.12 so that the conformance tests tolerate this

I was going through this doc: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md , but its not clear, so should I create cherry-pick PRs manually?

@smarterclayton
Copy link
Contributor

smarterclayton commented Oct 8, 2018 via email

@aveshagarwal
Copy link
Member Author

aveshagarwal commented Oct 8, 2018 via email •
edited by smarterclayton
Loading

@aveshagarwal
Copy link
Member Author

@feiskyer for 1.12
@foxish for 1.11
@MaciekPytel for 1.10

to have this PR cherry-picked in 1.12/11/10

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 9, 2018
@smarterclayton
Copy link
Contributor

I updated the description and release note of this PR with more data about why this needs a back port.

@feiskyer
Copy link
Member

@aveshagarwal Please create cherry pick PRs for each branch

This was referenced Oct 17, 2018
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 19, 2018
@k8s-ci-robot
Merge pull request #69912 from aveshagarwal/automated-cherry-pick-of-…
5d83597 
…#68793-upstream-release-1.11

Automated cherry pick of #68793: Fix DS tests to set their namespaces to empty node selectors
k8s-ci-robot added a commit that referenced this pull request Oct 23, 2018
@k8s-ci-robot
Merge pull request #69910 from aveshagarwal/automated-cherry-pick-of-…
00c7c33 
…#68793-upstream-release-1.12

Automated cherry pick of #68793: Fix DS tests to set their namespaces to empty node selectors
k8s-ci-robot added a commit that referenced this pull request Oct 29, 2018
@k8s-ci-robot
Merge pull request #69913 from aveshagarwal/automated-cherry-pick-of-…
60ab489 
…#68793-upstream-release-1.10

Automated cherry pick of #68793: Fix DS tests to set their namespaces to empty node selectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aveshagarwal @smarterclayton @neolit123 @k8s-ci-robot @feiskyer