Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore *filter table for ipvs #68786

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Restore *filter table for ipvs #68786

merged 1 commit into from
Sep 19, 2018

Conversation

alexjx
Copy link
Contributor

@alexjx alexjx commented Sep 18, 2018 •
edited
Loading

What this PR does / why we need it:
This PR tries to put back the *filter rules in ipvs mode of kube-proxy, which was missing due to a potential merge error.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68194

Special notes for your reviewer:

Release note:

kube-proxy restores the *filter table when running in ipvs mode.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 18, 2018
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 18, 2018
@alexjx
Copy link
Contributor Author

alexjx commented Sep 18, 2018

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 18, 2018
@alexjx
Copy link
Contributor Author

alexjx commented Sep 18, 2018

/assign @m1093782566

@neolit123
Copy link
Member

@alexjx thank you for the PR!

please add a release note explaining the fix, instead of NONE.

/kind bug
/ok-to-test

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 19, 2018
@alexjx
Copy link
Contributor Author

alexjx commented Sep 19, 2018

Updated. Thanks.

Jia

@m1093782566
Copy link
Contributor

cc @Lion-Wei for review

Lion-Wei
Lion-Wei reviewed Sep 19, 2018
View reviewed changes
Copy link

@Lion-Wei Lion-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2018
@m1093782566
Copy link
Contributor

/approve

Thanks for catching this! @alexjx

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexjx, Lion-Wei, m1093782566

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2018
@alexjx
Copy link
Contributor Author

alexjx commented Sep 19, 2018

Glad to contribute. :)

Jia

@m1093782566
Copy link
Contributor

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 19, 2018
@alexjx
Copy link
Contributor Author

alexjx commented Sep 19, 2018 •
edited
Loading

@m1093782566
From my understanding 1.12 is currently code freeze, and /priority critical-urgent is needed to merge.
How would I get that priority justified and tagged?

Jia

@m1093782566
Copy link
Contributor

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 19, 2018
@alexjx
Copy link
Contributor Author

alexjx commented Sep 19, 2018

Thanks!

@k8s-ci-robot k8s-ci-robot merged commit e3dbad3 into kubernetes:master Sep 19, 2018
@alexjx alexjx deleted the pr/68194 branch September 19, 2018 14:42
k8s-ci-robot added a commit that referenced this pull request Apr 1, 2019
@k8s-ci-robot
Merge pull request #75684 from rramkumar1/automated-cherry-pick-of-#6…
9820dd6 
…8786-upstream-release-1.11

Automated cherry pick of #68786 on release 1.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lion-Wei Lion-Wei Lion-Wei left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@m1093782566 m1093782566

@Lion-Wei Lion-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

kube-proxy ipvs mode does not populate filter table. (merge issue or intentional?)
5 participants
@alexjx @k8s-ci-robot @neolit123 @m1093782566 @Lion-Wei