Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply user configurations for local etcd #68334

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Apply user configurations for local etcd #68334

merged 1 commit into from
Sep 10, 2018

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Sep 6, 2018 •
edited
Loading

What this PR does / why we need it:
fix kubeadm bug
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68333

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

What happened:
When I use kubeadm to create a cluster, the specified parameter "listen-client-urls" does not work.
kubeadm init --config=kube-config.yaml fail with connection refuse for get http://127.0.0.1:2379
I think the element 'listen-client-urls' is unrecognized if the customized value is not equal '127.0.0.1'
Here is my kube-config.yaml

apiVersion: kubeadm.k8s.io/v1alpha2
kind: MasterConfiguration
apiServerCertSANs:    
- 192.168.192.128
- kube-dev
api:
  advertiseAddress: 192.168.192.128
  bindPort: 6440
bootstrapTokens:
- groups:
  - system:bootstrappers:kubeadm:default-node-token
  token: abcdef.0123456789abcdef
  ttl: 48h0m0s
  usages:
  - signing
  - authentication
etcd:
  local:
    extraArgs:
      listen-client-urls: https://192.168.192.128:2379
      advertise-client-urls: https://192.168.192.128:2379
      listen-peer-urls: https://192.168.192.128:2380
      initial-advertise-peer-urls: https://192.168.192.128:2380
      initial-cluster: kube-dev=https://192.168.192.128:2380
      initial-cluster-state: new
    serverCertSANs:
      - kube-dev
      - 192.168.192.128
    peerCertSANs:
      - kube-dev
      - 192.168.192.128
ServerExtraArgs:
  endpoint-reconciler-type: lease

networking:
  podSubnet: 192.168.0.0/16  
kubernetesVersion: v1.11.2 
featureGates:  
   CoreDNS: true

No matter how I set the "listen-client-urls" parameter in the kube-config.yaml ,
it is awlays be "https://127.0.0.1:2379"

What you expected to happen:
The parameter "listen-client-urls" can work!
How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

Kubernetes version (use kubectl version): v1.11.2
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release): CentOS Linux release 7.5.1804 (Core)
Kernel (e.g. uname -a): Linux kube-dev 3.10.0-862.el7.x86_64 #1 SMP Fri Apr 20 16:44:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Install tools:
Others:

Special notes for your reviewer:

Release note:

kubeadm: if defined, pass the local etcd value of `listen-client-urls` as `etcd-servers` argument to kube-apiserver.

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 6, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2018
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2018
@xiangpengzhao
Copy link
Contributor

xiangpengzhao commented Sep 6, 2018 •
edited
Loading

This LGTM. Can you please sign your CLA before we can merge this PR?
/ok-to-test

edit: cool, the bot detects the CLA status.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 6, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 6, 2018
@neolit123
Copy link
Member

@SataQiu
thanks for the bug fix!

please replace the release note NONE with:

kubeadm: if defined, pass the local etcd value of `listen-client-urls` as `etcd-servers` argument to kube-apiserver.

(or something in those lines)

/lgtm
/assign @timothysc

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 7, 2018
@SataQiu
Copy link
Member Author

SataQiu commented Sep 10, 2018

/retest

@neolit123
Copy link
Member

/test pull-kubernetes-e2e-kops-aws

@timothysc timothysc added this to the v1.12 milestone Sep 10, 2018
@timothysc timothysc added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 10, 2018
timothysc
timothysc approved these changes Sep 10, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, SataQiu, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit ef62882 into kubernetes:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@chuckha chuckha Awaiting requested review from chuckha

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@timothysc timothysc

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

kubeadm can not apply user specified listen-client-urls for local etcd
5 participants
@SataQiu @k8s-ci-robot @xiangpengzhao @neolit123 @timothysc