/sig api-machinery

cc @fedebongio

hi @cheftako , could u do all the lint fix for pkg/kubeapiserver/* too? we get ~800 pkgs to fix in total. it'll be flooding if we fix it one by one.

pkg/kubeapiserver
pkg/kubeapiserver/admission
pkg/kubeapiserver/authenticator
pkg/kubeapiserver/authorizer
pkg/kubeapiserver/authorizer/modes
pkg/kubeapiserver/options

Hi @yue9944882 I get the idea. Personally I think we should encourage small PRs like this. They are easy to inspect and know they are correct which makes them easier to review and approve than larger PRs which hit many files and cover a variety of different fixes. Should we need to roll it back we are rolling back just the problematic code and not other things as well. Lastly I think we need to encourage participation /engagement in the project. Indicating to people we won't accept their work unless they do more may not be the best way to go about that.

They are easy to inspect and know they are correct which makes them easier to review and approve than larger PRs which hit many files and cover a variety of different fixes.

take this pull as example, the requested owner area is pkg/kubeapiserver. tho we involve more sub-pkgs under it, it's doesn't request any more load of owners. but yeah, putting several pkgs into a pull makes it a bit harder to review but maybe we can divide the change into several logical commits to sort things clear. especially for such one-liner pulls.

it's just a polite suggestion. my point is that if we deal with the pkgs one-by-one, it'll possibly take us year-ish time to close the issue.

/test pull-kubernetes-integration

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here