-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup openstack cloud provider loadbalancer deletion error #68188
Fixup openstack cloud provider loadbalancer deletion error #68188
Conversation
This change enables ```getLoadBalancer``` to return the loadbalancer even if no floating ip is associated to the VIP port of the loadbalancer. Signed-off-by: Eunsoo Park <esevan.park@gmail.com>
/sig cloud-provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thank you!
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@dims can you approve ?
@yastij Just wait to pass the e2e tests. |
@FengyunPan2 - played a bit with this, as we needed it. Works as intended. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: esevan, FengyunPan2, yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-gce |
@FengyunPan2 Do we still need to support this in-tree openstack cloud provider? This has already been marked as deprecated and will be removed in future releases. We should use https://github.com/kubernetes/cloud-provider-openstack instead. /cc @dims /hold |
@dixudx we should keep both tree(s) in sync until v1.13 opens up in k/k. at that point, i'll submit a PR to entirely remove the tree. /hold cancel |
/retest |
/milestone v1.12 |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 68135, 68188). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. |
@esevan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This change enables
getLoadBalancer
to return the loadbalancer even if no floating ip is associated to the VIP port of the loadbalancer.Signed-off-by: Eunsoo Park esevan.park@gmail.com
What this PR does / why we need it:
This PR fixes the bug like below.
Special notes for your reviewer:
Refer to following bug description for better understanding of this PR.
When k8s service type is changed from LoadBalancer to others, there's a deleting loadbalancer process in kubernetes cloud provider as below.
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/service/service_controller.go#L284
Openstack cloud provider returns error even though LB exists since there's no associated floating IP with VIP port.
https://github.com/kubernetes/kubernetes/blob/master/pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go#L476
This caused
GetLoadBalancer()
failed and retrying over and over inprocessServiceUpdate
ofk8sServiceController
.Release note: