Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update etcd client to 3.2.24 for latest release #68147

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Update etcd client to 3.2.24 for latest release #68147

merged 1 commit into from
Sep 5, 2018

Conversation

timothysc
Copy link
Member

What this PR does / why we need it:
Updates etcd client to 3.2.24 which is the latest in the 3.2 series. See https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.2.md for details.

Special notes for your reviewer:
This is only the client, in order to update the server components it requires a googler to push the 3.2.24 image.

Release note:

Update etcd client interface to 3.2.24

/assign @jpbetz @wojtek-t
/cc @liggitt @kubernetes/sig-cluster-lifecycle @kubernetes/sig-scalability-pr-reviews

@timothysc timothysc added this to the v1.12 milestone Aug 31, 2018
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 31, 2018
@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2018
@k8s-ci-robot k8s-ci-robot requested a review from liggitt August 31, 2018 19:01
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 31, 2018
@timothysc timothysc added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 31, 2018
@timothysc
Copy link
Member Author

/assign @gyuho

@k8s-ci-robot
Copy link
Contributor

@timothysc: GitHub didn't allow me to assign the following users: gyuho.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @gyuho

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2018
@timothysc
Copy link
Member Author

/retest

@gyuho
Copy link
Member

gyuho commented Aug 31, 2018

@timothysc @jpbetz

From v3.2.13 to v3.2.24.

Most changes were made in server-side.

Client-side changes are:

@timothysc
Copy link
Member Author

@gyuho thx.

Only a googler can push the server side changes so I'm blocked on that.

@dims
Copy link
Member

dims commented Aug 31, 2018

cc @ixdy

@timothysc
Copy link
Member Author

/cc @kubernetes/sig-release-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Sep 1, 2018
@dixudx
Copy link
Member

dixudx commented Sep 1, 2018

@timothysc this looks good to me.

Please rebase it. Thanks for the work. 👍

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2018
@wojtek-t
Copy link
Member

wojtek-t commented Sep 3, 2018

/approve

@timothysc - please rebase

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2018
@jpbetz
Copy link
Contributor

jpbetz commented Sep 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2018
@timothysc
Copy link
Member Author

timothysc commented Sep 4, 2018 •
edited
Loading

I'm not going to be able to finish this until this evening due to other restrictions.
This particular change is more of a bug fix and low risk.

@timothysc
Update etcd client to 3.2.24 for latest release
0bb21f6 
Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 5, 2018
@timothysc
Copy link
Member Author

@wojtek-t PTAL, I'll check back in the morning.

@xiangpengzhao
Copy link
Contributor

BTW, do we want to use the new path github.com/etcd-io/etcd for import or still use github.com/coreos/etcd and let it be redirected?

@gyuho
Copy link
Member

gyuho commented Sep 5, 2018

@xiangpengzhao We still use old import paths for release branches.

@wojtek-t
Copy link
Member

wojtek-t commented Sep 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, timothysc, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timothysc timothysc added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 5, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 67691, 68147). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 2811228 into kubernetes:master Sep 5, 2018
@hexfusion hexfusion mentioned this pull request Sep 6, 2018
Closed
@timothysc timothysc mentioned this pull request Sep 6, 2018
Merged
@bruceauyeung bruceauyeung mentioned this pull request Sep 6, 2018
Closed
k8s-github-robot pushed a commit that referenced this pull request Sep 7, 2018
Merge pull request #68318 from timothysc/etcd-3-2-24
3617462 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Update default etcd server to 3.2.24 for kubernetes 1.12

**What this PR does / why we need it**:
Update default etcd server to 3.2.24 for kubernetes 1.12

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
xref #68147 

**Special notes for your reviewer**:
NONE

**Release note**:

```
Update default etcd server to 3.2.24 for kubernetes 1.12
```

/assign @wojtek-t @jpbetz @dims 
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @gyuho
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@jpbetz jpbetz

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/etcd cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
9 participants
@timothysc @k8s-ci-robot @gyuho @dims @dixudx @wojtek-t @jpbetz @xiangpengzhao @k8s-github-robot