Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Horizontal Pod Autoscaler update frequency to every 15s #68021

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Increase Horizontal Pod Autoscaler update frequency to every 15s #68021

merged 1 commit into from
Sep 3, 2018

Conversation

krzysztof-jastrzebski
Copy link
Contributor

@krzysztof-jastrzebski krzysztof-jastrzebski commented Aug 29, 2018 •
edited
Loading

What this PR does / why we need it:
PR increases Horizontal Pod Autoscaler default update interval (30s -> 15s). It will improve HPA reaction time for metric changes.

Release note:

Increase Horizontal Pod Autoscaler default update interval (30s -> 15s). It will improve HPA reaction time for metric changes.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2018
@krzysztof-jastrzebski
Copy link
Contributor Author

/assign mwielgus

@mwielgus mwielgus added this to the v1.12 milestone Aug 29, 2018
@mwielgus mwielgus added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Aug 29, 2018
@mwielgus
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 29, 2018
@mwielgus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018
@mwielgus
Copy link
Contributor

cc: @DirectXMan12

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Aug 29, 2018 •
edited
Loading

Is there any significant performance issues from reconciling twice as much? Release note should say "default interval". Also, we really should be putting these in place way earlier in the cycle, so that we can notice any issues way before code freeze.

I also question how much of an impact this is going to have, considering that the default scrape interval on metrics-server is currently still 1 minute...

@krzysztof-jastrzebski
Copy link
Contributor Author

Release notes are fixed.
We are going to change scraping on metrics-server to 30s.
This should improve HPA latancy even without changing scrape interval as HPA will faster notice new metrics.

@serathius serathius mentioned this pull request Aug 31, 2018
Merged
@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@krzysztof-jastrzebski
Copy link
Contributor Author

/assign wojtek-t

k8s-github-robot pushed a commit that referenced this pull request Sep 3, 2018
Merge pull request #68127 from serathius/metrics-server-30s
6701e24 
Automatic merge from submit-queue (batch tested with PRs 68127, 68143). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Increase metrics-server scrape frequency to 30s

With new release of metrics-server and it's performance improvement, we will reduce metrics pipeline latency from 60s to 30s. 
This is part of sig-autoscaling effort to improve HPA #68021
```release-note
Increase scrape frequency of metrics-server to 30s
```
/cc @kawych @mwielgus @DirectXMan12 @dashpole
@wojtek-t
Copy link
Member

wojtek-t commented Sep 3, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, krzysztof-jastrzebski, mwielgus, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 5e9a3ad into kubernetes:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@DirectXMan12 DirectXMan12

@wojtek-t wojtek-t

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
6 participants
@krzysztof-jastrzebski @mwielgus @DirectXMan12 @wojtek-t @k8s-ci-robot @k8s-github-robot