isolate logging resources in separate namespace #68004

saravanan30erd · 2018-08-29T12:11:59Z

What this PR does / why we need it:
Now all the resources(ES, fluentd, kibana) are creating in kube-system namespace which supposed to have only k8s components, so isolated these resources in separate namespace logging.

Release note:

fluentd: isolate logging resources in separate namespace

saravanan30erd · 2018-08-29T12:13:12Z

/assign coffeepac

neolit123 · 2018-08-29T15:21:10Z

thanks for the PR
please change the release note to:
fluend: isolate logging resources in separate namespace

/kind feature
/remove-sig cluster-lifecycle
/sig instrumentation
(TODO: need to add labels for this one.)

neolit123 · 2018-08-29T15:21:36Z

/ok-to-test

saravanan30erd · 2018-08-29T16:52:29Z

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gke
/test pull-kubernetes-e2e-gce

coffeepac · 2018-08-29T17:09:24Z

I think this will break updates of the addon. I am in favor of this change but we need to be careful/explicit and possibly build in some backwards compatibility somehow.

a bit short on time right now, but will think more about this and maybe try some things out.

@piosz do you have any thoughts on this? I think we've had this discussion before.

krmayankk · 2018-08-30T06:19:08Z

cluster/addons/fluentd-elasticsearch/create-logging-namespace.yaml

+kind: Namespace
+apiVersion: v1
+metadata:
+ name: logging


kube-logging ?

saravanan30erd · 2018-08-30T06:25:06Z

/test pull-kubernetes-e2e-kops-aws

fejta-bot · 2019-01-19T19:19:50Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

coffeepac · 2019-01-22T04:27:42Z

/remove-lifecycle stale

monotek · 2019-01-22T09:42:15Z

@coffeepac
Imho also Elasticsearch should go to the new namespace:

What about the all the stuff in fluentd-gcp?
https://github.com/kubernetes/kubernetes/tree/master/cluster/addons/fluentd-gcp

@krmayankk
I would also keep the name "logging" as also non kube apps would use the apps in this namespace.

fejta-bot · 2019-04-28T21:24:56Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2019-05-28T22:07:38Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

saravanan30erd · 2021-03-16T05:41:46Z

@coffeepac updated the versions for k8s objects.

coffeepac · 2021-03-16T15:43:06Z

looks good! @monotek do you have any comments or objections on this? I'm assuming the chart overrides the namespace already anyway.

and we should go move the other logging thing as well. though I'm not an owner so we'll have to track someone down.

coffeepac · 2021-03-16T15:44:34Z

/retest

monotek

/lgtm
/approve

fejta-bot · 2021-03-17T20:47:40Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

k8s-ci-robot · 2021-03-17T20:47:53Z

@fejta-bot: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

monotek · 2021-03-17T20:51:19Z

/retest

pacoxu · 2021-03-18T03:43:18Z

cluster/addons/fluentd-elasticsearch/es-statefulset.yaml

@@ -28,15 +28,15 @@ rules:
 kind: ClusterRoleBinding
 apiVersion: rbac.authorization.k8s.io/v1
 metadata:
-  namespace: kube-system
+  namespace: logging


ClusterRoleBinding is not namespaced.
This line should be removed.

good catch, thank you, please remove this line @saravanan30erd

@coffeepac Its done

pacoxu · 2021-03-18T03:46:17Z

cluster/addons/fluentd-elasticsearch/es-statefulset.yaml

  template:
    metadata:
      labels:
        k8s-app: elasticsearch-logging
-        version: v7.4.3
+        version: v7.4.4


- image: quay.io/fluentd_elasticsearch/elasticsearch:v7.4.3

The image here is 7.4.3.
Why the version is changed to v7.4.4 in labels?

the label version is for the entire statefulset. I believe updating the namespace is sufficient to rev the patch version at least. but the image isn't moving.

these will get back in-sync with the next minor release of the image.

coffeepac · 2021-03-19T02:41:24Z

/hold

monotek · 2021-03-19T09:37:14Z

/lgtm

k8s-ci-robot · 2021-03-19T09:37:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coffeepac, monotek, saravanan30erd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cluster/addons/fluentd-elasticsearch/OWNERS~~ [coffeepac,monotek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coffeepac · 2021-03-22T16:02:02Z

/hold cancel

coffeepac · 2021-03-22T16:03:24Z

/milestone v1.21

k8s-ci-robot · 2021-03-22T16:03:26Z

@coffeepac: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coffeepac · 2021-03-26T02:29:01Z

@saravanan30erd I know what the process is now. however, in order to get added to a milestone (it doesn't matter which one) I will also need to sort out a new home for this addon. it really shouldn't be in k/k anymore.

saravanan30erd · 2021-08-25T06:57:36Z

@saravanan30erd I know what the process is now. however, in order to get added to a milestone (it doesn't matter which one) I will also need to sort out a new home for this addon. it really shouldn't be in k/k anymore.

@coffeepac this addon still in k/k or is it moved to somewhere?

k8s-ci-robot requested review from coffeepac and piosz August 29, 2018 12:12

k8s-ci-robot assigned coffeepac Aug 29, 2018

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Aug 29, 2018

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 29, 2018

krmayankk reviewed Aug 30, 2018

View reviewed changes

cluster/addons/fluentd-elasticsearch/create-logging-namespace.yaml

kind: Namespace

apiVersion: v1

metadata:

name: logging

Copy link

krmayankk Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kube-logging ?

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2018

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2019

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2019

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2019

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 28, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021

update version for addon fluentd ES

f0a95b8

monotek approved these changes Mar 17, 2021

View reviewed changes

k8s-ci-robot assigned monotek Mar 17, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2021

pacoxu reviewed Mar 18, 2021

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2021

remove namespace for clusterRoleBinding object - fluentd-es addon

b9696ae

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2021

monotek approved these changes Mar 19, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2021

k8s-ci-robot merged commit d8f3794 into kubernetes:master Apr 8, 2021

k8s-ci-robot added this to the v1.22 milestone Apr 8, 2021

github-actions bot mentioned this pull request Apr 21, 2021

Week Ending April 14, 2021 dev-obs/actus#357

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

isolate logging resources in separate namespace #68004

isolate logging resources in separate namespace #68004

saravanan30erd commented Aug 29, 2018 •

edited

Loading

saravanan30erd commented Aug 29, 2018

neolit123 commented Aug 29, 2018

neolit123 commented Aug 29, 2018

saravanan30erd commented Aug 29, 2018

coffeepac commented Aug 29, 2018 •

edited

Loading

krmayankk Aug 30, 2018

saravanan30erd commented Aug 30, 2018

fejta-bot commented Jan 19, 2019

coffeepac commented Jan 22, 2019

monotek commented Jan 22, 2019 •

edited

Loading

fejta-bot commented Apr 28, 2019

fejta-bot commented May 28, 2019

saravanan30erd commented Mar 16, 2021

coffeepac commented Mar 16, 2021 •

edited

Loading

coffeepac commented Mar 16, 2021

monotek left a comment

fejta-bot commented Mar 17, 2021

k8s-ci-robot commented Mar 17, 2021

monotek commented Mar 17, 2021

pacoxu Mar 18, 2021

coffeepac Mar 18, 2021

saravanan30erd Mar 19, 2021

pacoxu Mar 18, 2021

coffeepac Mar 18, 2021

coffeepac commented Mar 19, 2021

monotek commented Mar 19, 2021

k8s-ci-robot commented Mar 19, 2021

coffeepac commented Mar 22, 2021

coffeepac commented Mar 22, 2021

k8s-ci-robot commented Mar 22, 2021

coffeepac commented Mar 26, 2021

saravanan30erd commented Aug 25, 2021

isolate logging resources in separate namespace #68004

isolate logging resources in separate namespace #68004

Conversation

saravanan30erd commented Aug 29, 2018 • edited Loading

saravanan30erd commented Aug 29, 2018

neolit123 commented Aug 29, 2018

neolit123 commented Aug 29, 2018

saravanan30erd commented Aug 29, 2018

coffeepac commented Aug 29, 2018 • edited Loading

krmayankk Aug 30, 2018

Choose a reason for hiding this comment

saravanan30erd commented Aug 30, 2018

fejta-bot commented Jan 19, 2019

coffeepac commented Jan 22, 2019

monotek commented Jan 22, 2019 • edited Loading

fejta-bot commented Apr 28, 2019

fejta-bot commented May 28, 2019

saravanan30erd commented Mar 16, 2021

coffeepac commented Mar 16, 2021 • edited Loading

coffeepac commented Mar 16, 2021

monotek left a comment

Choose a reason for hiding this comment

fejta-bot commented Mar 17, 2021

k8s-ci-robot commented Mar 17, 2021

monotek commented Mar 17, 2021

pacoxu Mar 18, 2021

Choose a reason for hiding this comment

coffeepac Mar 18, 2021

Choose a reason for hiding this comment

saravanan30erd Mar 19, 2021

Choose a reason for hiding this comment

pacoxu Mar 18, 2021

Choose a reason for hiding this comment

coffeepac Mar 18, 2021

Choose a reason for hiding this comment

coffeepac commented Mar 19, 2021

monotek commented Mar 19, 2021

k8s-ci-robot commented Mar 19, 2021

coffeepac commented Mar 22, 2021

coffeepac commented Mar 22, 2021

k8s-ci-robot commented Mar 22, 2021

coffeepac commented Mar 26, 2021

saravanan30erd commented Aug 25, 2021

saravanan30erd commented Aug 29, 2018 •

edited

Loading

coffeepac commented Aug 29, 2018 •

edited

Loading

monotek commented Jan 22, 2019 •

edited

Loading

coffeepac commented Mar 16, 2021 •

edited

Loading