Add some initial validation logic. #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #654 |
brendandburns
changed the title
| detect-minions > /dev/null | ||
|
|
||
| MINIONS_FILE=/tmp/minions | ||
| $(dirname $0)/kubecfg.sh list minions > ${MINIONS_FILE} |
There was a problem hiding this comment.
Recommend using the -template parameter to get output that's robust across kubecfg.sh default printer changes.
There was a problem hiding this comment.
Missing a push? Seems the same...
|
I also was hoping for some sort of verification that master and minions are in agreement about what the minion is called in etcd, which is harder to check. Maybe minion could serve the key it is using and you could check through the proxy? |
|
Let's put further validation into a different PR. I think that the best thing might be to have a parameter for the kubelet /healthz? that includes the name of the kubelet, and validate that it matches. |
|
This is ready to merge. |
brendandburns
changed the title
|
ok, actually pushed this time... |
lavalamp
added a commit
that referenced
this pull request
Jul 29, 2014
Add some initial validation logic.
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
Add Collector executor support
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Dec 8, 2016
* support docker deployment and fix bug * support offline * update * generate configmap * add restore * support cyclone and fix bug * fix * fix * fix
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Mar 3, 2017
* support docker deployment and fix bug * support offline * update * generate configmap * add restore * support cyclone and fix bug * fix * fix * fix
seans3
pushed a commit
to seans3/kubernetes
that referenced
this pull request
Apr 10, 2019
add initial KEP for maxUnavailable in StatefulSets
linxiulei
pushed a commit
to linxiulei/kubernetes
that referenced
this pull request
Jan 18, 2024
Add condition message to event message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.