Runtimeclass podapi #67737

tallclair · 2018-08-23T00:20:36Z

Adds (but doesn't implement) the RuntimeClass Pod API proposed in https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md

Based on the result (lazy consensus) of the alpha fields discussion on sig-architecture: https://groups.google.com/forum/#!topic/kubernetes-sig-architecture/y9FulL9Uq6A

For kubernetes/enhancements#585

Special notes for your reviewer:

Release note:

RuntimeClass is a new API resource for defining different classes of runtimes that may be used to run containers in the cluster. Pods can select a RuntimeClass to use via the RuntimeClassName field. This feature is in alpha, and the RuntimeClass feature gate must be enabled in order to use it.

/sig node
/kind api-change
/priority important-soon
/milestone v1.12

tallclair · 2018-08-23T00:21:36Z

/assign @dchen1107
/assign @thockin

thockin · 2018-08-23T19:34:30Z

pkg/apis/core/types.go

+	// More info: https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md
+	// This is an alpha feature and may change in the future.
+	// +optional
+	RuntimeClassName string


All new optional fields must be pointers.

thockin · 2018-08-23T19:34:46Z

pkg/apis/core/types.go

@@ -2571,6 +2571,12 @@ type PodSpec struct {
 	// More info: https://github.com/kubernetes/community/blob/master/keps/sig-network/0007-pod-ready%2B%2B.md
 	// +optional
 	ReadinessGates []PodReadinessGate
+	// RuntimeClassName refers to a RuntimeClass object with the same name, which should be used to


Can we be more precise about which apigroup this type exists in?

thockin · 2018-08-23T19:35:22Z

pkg/apis/core/types.go

@@ -2571,6 +2571,12 @@ type PodSpec struct {
 	// More info: https://github.com/kubernetes/community/blob/master/keps/sig-network/0007-pod-ready%2B%2B.md
 	// +optional
 	ReadinessGates []PodReadinessGate
+	// RuntimeClassName refers to a RuntimeClass object with the same name, which should be used to
+	// run this pod.  If no RuntimeClass resource matches the named class, the pod will not be run.


Document what happens when this is unset.

lavalamp · 2018-08-23T20:16:27Z

/remove-sig api-machinery

tallclair · 2018-08-23T20:33:01Z

/remove-sig api-machinery
/remove-sig apps

tallclair · 2018-08-23T20:37:15Z

Thanks for the feedback @thockin
All comments addressed.

thockin · 2018-08-23T21:57:22Z

/lgtm
/approve

k8s-ci-robot · 2018-08-23T21:58:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tallclair, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [thockin]
~~docs/api-reference/OWNERS~~ [thockin]
~~pkg/api/OWNERS~~ [thockin]
~~pkg/apis/core/OWNERS~~ [thockin]
~~pkg/features/OWNERS~~ [tallclair,thockin]
~~staging/src/k8s.io/api/OWNERS~~ [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-github-robot · 2018-08-23T22:40:43Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2018-08-23T23:53:28Z

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

Automatic merge from submit-queue (batch tested with PRs 67578, 68154, 68162, 65545). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Add RuntimeClass read permission for nodes **What this PR does / why we need it**: Add the necessary permissions for nodes to read RuntimeClasses when the feature gate is enabled. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: For kubernetes/enhancements#585 **Release note**: Covered by #67737 ```release-note NONE ``` /sig node /sig auth /kind feature /priority important-soon /milestone v1.12

Automatic merge from submit-queue (batch tested with PRs 68161, 68023, 67909, 67955, 67731). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Dynamic RuntimeClass implementation **What this PR does / why we need it**: Implement RuntimeClass using the dynamic client to break the dependency on #67791 Once (if) #67791 merges, I will migrate to the typed client. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: For kubernetes/enhancements#585 **Release note**: Covered by #67737 ```release-note NONE ``` /sig node /kind feature /priority important-soon /milestone v1.12

Automatic merge from submit-queue (batch tested with PRs 68161, 68023, 67909, 67955, 67731). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Register RuntimeClass CRD as an addon **What this PR does / why we need it**: Register the RuntimeClass CRD when the RuntimeClass feature gate is enabled. This is done in through the addon manager. This is an alternative approach to #67924 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: For kubernetes/enhancements#585 **Release note**: Covered by #67737 ```release-note NONE ``` /sig node /kind feature /priority important-soon /milestone v1.12

alexmavr · 2018-10-25T18:09:57Z

There's a typo in the release note: RunitmeClass

tallclair added 2 commits August 22, 2018 14:26

WIP: RC pods

7f64bb6

Generated code

87164e0

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 23, 2018

k8s-ci-robot added this to the v1.12 milestone Aug 23, 2018

k8s-ci-robot requested review from erictune and gmarek August 23, 2018 00:20

k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Aug 23, 2018

k8s-ci-robot assigned dchen1107 and thockin Aug 23, 2018

tallclair mentioned this pull request Aug 23, 2018

API Review: RuntimeClass kubernetes-retired/architecture-tracking#48

Closed

thockin reviewed Aug 23, 2018

View reviewed changes

Address @thockin feedback

4b8050e

k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 23, 2018

regenerate files

f5cc053

tallclair removed the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Aug 23, 2018

k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Aug 23, 2018

k8s-ci-robot removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Aug 23, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2018

k8s-github-robot merged commit 40063e8 into kubernetes:master Aug 23, 2018

This was referenced Aug 24, 2018

Add node-api staging repo w/ RuntimeClass API #67791

Merged

Dynamic RuntimeClass implementation #67909

Merged

Register RuntimeClass CRD in nodelifecycle controller #67924

Closed

This was referenced Sep 1, 2018

Register RuntimeClass CRD as an addon #68161

Merged

Add RuntimeClass read permission for nodes #68162

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Runtimeclass podapi #67737

Runtimeclass podapi #67737

tallclair commented Aug 23, 2018 •

edited

Loading

tallclair commented Aug 23, 2018

thockin Aug 23, 2018

tallclair Aug 23, 2018

thockin Aug 23, 2018

tallclair Aug 23, 2018

thockin Aug 23, 2018

tallclair Aug 23, 2018

lavalamp commented Aug 23, 2018

tallclair commented Aug 23, 2018

tallclair commented Aug 23, 2018

thockin commented Aug 23, 2018

k8s-ci-robot commented Aug 23, 2018

k8s-github-robot commented Aug 23, 2018

k8s-github-robot commented Aug 23, 2018

alexmavr commented Oct 25, 2018

Runtimeclass podapi #67737

Runtimeclass podapi #67737

Conversation

tallclair commented Aug 23, 2018 • edited Loading

tallclair commented Aug 23, 2018

thockin Aug 23, 2018

Choose a reason for hiding this comment

tallclair Aug 23, 2018

Choose a reason for hiding this comment

thockin Aug 23, 2018

Choose a reason for hiding this comment

tallclair Aug 23, 2018

Choose a reason for hiding this comment

thockin Aug 23, 2018

Choose a reason for hiding this comment

tallclair Aug 23, 2018

Choose a reason for hiding this comment

lavalamp commented Aug 23, 2018

tallclair commented Aug 23, 2018

tallclair commented Aug 23, 2018

thockin commented Aug 23, 2018

k8s-ci-robot commented Aug 23, 2018

k8s-github-robot commented Aug 23, 2018

k8s-github-robot commented Aug 23, 2018

alexmavr commented Oct 25, 2018

tallclair commented Aug 23, 2018 •

edited

Loading