Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report cloudstack hostname address #67719

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Report cloudstack hostname address #67719

merged 1 commit into from
Aug 27, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 22, 2018 •
edited
Loading

Cloud providers are now authoritative for the addresses reported by the kubelet. Cloud providers that have hostname information available via metadata should report it for use by the apiserver

The cloudstack cloud provider now reports a `Hostname` address type for nodes based on the `local-hostname` metadata key.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 22, 2018
@liggitt liggitt mentioned this pull request Aug 22, 2018
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Aug 22, 2018
@liggitt
Copy link
Member Author

liggitt commented Aug 23, 2018

/retest

/assign @ngtuna @sebgoa @svanharmelen

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 23, 2018
svanharmelen
svanharmelen reviewed Aug 23, 2018
View reviewed changes
Copy link

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @liggitt! I left one small comment we should address...

pkg/cloudprovider/providers/cloudstack/metadata.go Outdated
if err != nil {
return nil, fmt.Errorf("could not get hostname: %v", err)
}
if len(hostname) > 0 {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it’s better (for readability) to check if it isn’t an empty string, instead of a non zero length.

This also us more consistent with other simular checks in this cloud provider.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@liggitt liggitt force-pushed the cloudstack-hostname branch from 9c9e986 to 7078bfe Compare August 24, 2018 04:11
svanharmelen
svanharmelen approved these changes Aug 24, 2018
View reviewed changes
Copy link

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liggitt
Copy link
Member Author

liggitt commented Aug 27, 2018

@svanharmelen thanks, can you tag with /lgtm for the bot?

@svanharmelen
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, svanharmelen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2018
@svanharmelen
Copy link

Sorry, just did the correct lgtm 😉

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 67447, 67719). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5299470 into kubernetes:master Aug 27, 2018
@liggitt liggitt deleted the cloudstack-hostname branch October 3, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanharmelen svanharmelen svanharmelen approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@vishh vishh Awaiting requested review from vishh

Assignees

@sebgoa sebgoa

@ngtuna ngtuna

@svanharmelen svanharmelen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @svanharmelen @k8s-ci-robot @k8s-github-robot @sebgoa @ngtuna