Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet: only apply default hard evictions of nodefs.inodesFree on Linux #67709

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Kubelet: only apply default hard evictions of nodefs.inodesFree on Linux #67709

merged 2 commits into from
Sep 5, 2018

Conversation

feiskyer
Copy link
Member

What this PR does / why we need it:

Kubelet sets default hard evictions of nodefs.inodesFree for all platforms today. This will cause errors on Windows and a lot no observation found for eviction signal nodefs.inodesFree errors will be logs for kubelet.

kubelet.err.log:4961:W0711 22:21:12.378789    2872 helpers.go:808] eviction manager: no observation found for eviction signal nodefs.inodesFree
kubelet.err.log:4967:W0711 22:21:30.411371    2872 helpers.go:808] eviction manager: no observation found for eviction signal nodefs.inodesFree
kubelet.err.log:4974:W0711 22:21:48.446456    2872 helpers.go:808] eviction manager: no observation found for eviction signal nodefs.inodesFree
kubelet.err.log:4978:W0711 22:22:06.482441    2872 helpers.go:808] eviction manager: no observation found for eviction signal nodefs.inodesFree

This PR updates the default hard eviction value and only apply nodefs.inodesFree on Linux.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #66088

Special notes for your reviewer:

Release note:

Kubelet only applies default hard evictions of nodefs.inodesFree on Linux

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 22, 2018
@k8s-ci-robot k8s-ci-robot requested review from dims and pmorie August 22, 2018 14:09
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 22, 2018
@feiskyer
Copy link
Member Author

/assign @tallclair @PatrickLang

@feiskyer feiskyer added this to the v1.12 milestone Aug 24, 2018
dims
dims approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2018
@feiskyer
Copy link
Member Author

/retest

@PatrickLang
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2018
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 3, 2018
@feiskyer feiskyer force-pushed the inodes-clean branch 2 times, most recently from 28b422b to 6ee09cd Compare September 3, 2018 07:42
@feiskyer
Copy link
Member Author

feiskyer commented Sep 3, 2018

/retest

@PatrickLang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2018
@PatrickLang
Copy link
Contributor

@dims can you review after rebase?

@PatrickLang
Copy link
Contributor

/assign @tallclair

@PatrickLang
Copy link
Contributor

/sig windows
(need to track there too, already have LGTM)

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Sep 4, 2018
@dims
Copy link
Member

dims commented Sep 4, 2018

/test pull-kubernetes-cross

@derekwaynecarr
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2018
@dchen1107
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, derekwaynecarr, dims, feiskyer, PatrickLang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer feiskyer added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 5, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 743e4fb into kubernetes:master Sep 5, 2018
@k8s-ci-robot
Copy link
Contributor

@feiskyer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized 8255318 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feiskyer feiskyer deleted the inodes-clean branch September 5, 2018 06:50
@miry
Copy link
Contributor

miry commented Feb 7, 2019

@feiskyer after those changes the tests are not passed in MacOS.

$ go test ./cmd/kubeadm/app/util/config/... -v -run TestConfigFileAndDefaultsToInternalConfig
    --- FAIL: TestConfigFileAndDefaultsToInternalConfig/incompleteYAMLToDefaultedv1beta1 (0.00s)
        initconfiguration_test.go:123: the expected and actual output differs.
            	in: testdata/defaulting/master/incomplete.yaml
            	out: testdata/defaulting/master/defaulted.yaml
            	groupversion: kubeadm.k8s.io/v1beta1
            	diff: 
            --- expected
            +++ actual
            @@ -115,7 +115,6 @@
               imagefs.available: 15%!
            (MISSING)   memory.available: 100Mi
               nodefs.available: 10%!
            (MISSING)-  nodefs.inodesFree: 5%!
            (MISSING) evictionPressureTransitionPeriod: 5m0s
             failSwapOn: true
             fileCheckFrequency: 20s

as you see nodefs.inodesFree: 5% is missing. Do you know any workaround for different os to have passed tests ?

@feiskyer
Copy link
Member Author

feiskyer commented Feb 8, 2019

as you see nodefs.inodesFree: 5% is missing. Do you know any workaround for different os to have passed tests ?

Yep, it is moved to only Linux now. Let me file another PR to fix this.

@feiskyer feiskyer mentioned this pull request Feb 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

@pmorie pmorie Awaiting requested review from pmorie

Assignees

@dims dims

@PatrickLang PatrickLang

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

Windows - eviction manager: no observation found for eviction signal nodefs.inodesFree
9 participants
@feiskyer @PatrickLang @dims @derekwaynecarr @dchen1107 @k8s-ci-robot @k8s-github-robot @miry @tallclair