-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CoreDNS as default for kube-up deployments #67569
Conversation
@rajansandeep : I spend long time to check the failing e2e tests for the other PR. And I guess there cases when the e2e pull-kubernetes-gce ends in cored dumped and then timeout. Could you set the flat "ok-to-test" ? Thanks! And, for sure, the I cannot reproduce on similar deployment e2e on GCE ... :) running:
result:
|
/ok-to-test |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5db6a05
to
f60dcbc
Compare
With consensus on the way to resolve this issue : kubernetes/dns#254 Adding port remapping to 10053. |
/unlabel area/apiserver |
I mad a mistaking in build the push ... and therefore for a few time had a lot of code. and the Bot added a lot of labels. @rajansandeep : do you have a way to remove the unecessary labels : all "area/..", "sig/xx" |
@kubernetes/sig-contributor-experience-bugs Hey contribex folks - Am I not able to LGTM something without approving? I see those two statements as very orthogonal. |
@thockin looking at the following
I can flip the config to set |
f60dcbc
to
96922ce
Compare
/test pull-kubernetes-e2e-kops-aws |
/retest |
1 similar comment
/retest |
@thockin : this PR is ready. This PR does not depend to any release of CoreDNS and can be applied immediately NOTE: I think it would be good to merge asap, so we can evaluate impact on ALL the e2e tests that uses kube-up to deploy a cluster for test. I would not expect issue ... but who knows ? |
@kubernetes/sig-network-pr-reviews @thockin |
/remove-kind bug |
/milestone v1.12 |
/test pull-kubernetes-e2e-gke |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fturib, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Automatic merge from submit-queue (batch tested with PRs 67745, 67432, 67569, 67825, 67943). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. |
What this PR does / why we need it:
Enable CoreDNS as default (for kube-up installations)
It will allow to run CI tests to prepare graduation criteria for CoreDNS as Default
see : KEP - https://github.com/kubernetes/community/blob/master/keps/sig-network/0012-20180518-coredns-default-proposal.md
see also : kubernetes/enhancements#566
NOTE for release : I guess that CoreDNS as default server for k8s needs a longer description. This specific PR is to ensure we validate all e2e.