Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod Ready++ cont #67406

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Pod Ready++ cont #67406

merged 2 commits into from
Aug 23, 2018

Conversation

freehan
Copy link
Contributor

@freehan freehan commented Aug 14, 2018 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2018
@freehan freehan changed the title Pod ready Pod Ready++ cont Aug 14, 2018
@freehan freehan added this to the v1.12 milestone Aug 14, 2018
@freehan freehan added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 14, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 14, 2018
@freehan freehan added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 14, 2018
@freehan freehan force-pushed the pod-ready branch 3 times, most recently from 81ba8e9 to 9d0f725 Compare August 15, 2018 21:00
@freehan
Copy link
Contributor Author

freehan commented Aug 15, 2018

Rebased

@freehan
Copy link
Contributor Author

freehan commented Aug 20, 2018

/test pull-kubernetes-e2e-kops-aws

yujuhong
yujuhong reviewed Aug 20, 2018
View reviewed changes
test/e2e/common/pods.go Outdated
By(fmt.Sprintf("patching pod status with condition %q to true", readinessGate1))
_, err := podClient.Patch(podName, types.StrategicMergePatchType, []byte(fmt.Sprintf(patchStatusFmt, readinessGate1, "True")), "status")
Expect(err).NotTo(HaveOccurred())
time.Sleep(maxReadyStatusUpdateTolerance)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of sleeping for a fix time, use Eventually or something similar to retry with a timeout.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you can just use the validatePodReadiness you wrote here as well for the first check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sleep for 10 seconds. Just to make sure that the status would not change after the reconcile loop takes place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. I misread your intention. Consider this resolved.

test/e2e/common/pods.go Outdated
buildBackOffDuration = time.Minute
syncLoopFrequency = 10 * time.Second
maxBackOffTolerance = time.Duration(1.3 * float64(kubelet.MaxContainerBackOff))
maxReadyStatusUpdateTolerance = 10 * time.Second
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this 20s to lower test flake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally want to make this 5 seconds. I think kubelet's internal reconcile loop triggers every 10 seconds. I want the status update to be responsive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I still think this might be flaky given that the tests are run in parallel. If you want to test the latency, running a serial test would be better.

10s might be okay now, but please monitor the tests to see if it causes any flake. Actually, could you replace the NodeConformance tag with [NodeFeature:] and promote it later once it's consistently passing?

@freehan
Copy link
Contributor Author

freehan commented Aug 20, 2018

/assign thockin for approval

@k8s-ci-robot
Copy link
Contributor

@freehan: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign thockin for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yujuhong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2018
@freehan
Copy link
Contributor Author

freehan commented Aug 21, 2018

Rebased. Reapplying lgtm

@freehan freehan added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2018
@tfogo
Copy link

tfogo commented Aug 21, 2018

Hi @freehan, I'm Tim, a docs shadow on the 1.12 release team. It looks like as part of this change, the docs would need to be updated (specifically it looks like we may want to update this). Could you please open a placeholder or WIP PR to the release-1.12 branch of k/website?

@dims
Copy link
Member

dims commented Aug 22, 2018

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 22, 2018
@freehan freehan mentioned this pull request Aug 22, 2018
Merged
@freehan
Copy link
Contributor Author

freehan commented Aug 22, 2018

@tfogo pushed a PR

@thockin
Copy link
Member

thockin commented Aug 23, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, thockin, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 67031, 67406). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a1c3e47 into kubernetes:master Aug 23, 2018
@alejandrox1 alejandrox1 mentioned this pull request Mar 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujuhong yujuhong yujuhong left review comments

@krousey krousey Awaiting requested review from krousey

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@thockin thockin

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
7 participants
@freehan @k8s-ci-robot @yujuhong @tfogo @dims @thockin @k8s-github-robot