Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use v1 version of advanced audit policy in kubeadm #67176

Merged
merged 1 commit into from
Aug 10, 2018
Merged

use v1 version of advanced audit policy in kubeadm #67176

merged 1 commit into from
Aug 10, 2018

Conversation

ChiuWang
Copy link
Contributor

@ChiuWang ChiuWang commented Aug 9, 2018 •
edited
Loading

audit api version has been updated to v1 #65891

Release note:

kubeadm uses audit policy v1 instead of v1beta1

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Aug 9, 2018
@ChiuWang ChiuWang mentioned this pull request Aug 9, 2018
Closed
@dixudx
Copy link
Member

dixudx commented Aug 9, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 9, 2018
@ChiuWang ChiuWang force-pushed the auditv1beta1Tov1_utils branch from 96ede60 to 765e2fc Compare August 9, 2018 11:38
fabriziopandini
fabriziopandini suggested changes Aug 10, 2018
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charrywanganthony Thanks for this PR!
Please add a release note (kubeadm now uses audit policy v1 instead of v1beta1)
/approve

@chuckha please take a look at this one
/CC @chuckha

@k8s-ci-robot k8s-ci-robot requested a review from chuckha August 10, 2018 06:31
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 10, 2018
@chuckha
Copy link
Contributor

chuckha commented Aug 10, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charrywanganthony, chuckha, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5de3896 into kubernetes:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini requested changes

@chuckha chuckha chuckha approved these changes

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@chuckha chuckha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChiuWang @dixudx @chuckha @k8s-ci-robot @k8s-github-robot @fabriziopandini