Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop kube-aggregator container image from release #67157

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Drop kube-aggregator container image from release #67157

merged 1 commit into from
Aug 15, 2018

Conversation

dims
Copy link
Member

@dims dims commented Aug 8, 2018 •
edited
Loading

What this PR does / why we need it:

First version of this was only standalone, now the code is integrated into kube-apiserver. So the standalone binary and
container are no longer useful.

Change-Id: Ib9369de66b4ecb3451f73ba2a252526d6615b96f

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Remove unused binary and container image for kube-aggregator. The functionality is already integrated into the kube-apiserver.

@dims
Drop kube-aggregator container image from release
a66e1f0 
First version of this was only standalone, now the code is being
vendored by anyone who wants to use it. So the standalone binary and
container are no longer useful.

Change-Id: Ib9369de66b4ecb3451f73ba2a252526d6615b96f
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 8, 2018
@k8s-ci-robot k8s-ci-robot requested review from vishh and zmerlynn August 8, 2018 20:00
@dims
Copy link
Member Author

dims commented Aug 8, 2018

cc @sttts @tpepper @kubernetes/sig-api-machinery-pr-reviews @kubernetes/sig-release-members

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 8, 2018
@dims
Copy link
Member Author

dims commented Aug 8, 2018

/sig api-machinery
/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Aug 8, 2018
@dims
Copy link
Member Author

dims commented Aug 8, 2018

/assign @lavalamp
/assign @cblecker

@sttts
Copy link
Contributor

sttts commented Aug 9, 2018

now the code is being
vendored by anyone who wants to use it

More correct: now it is integrated into kube-apiserver.

@deads2k
Copy link
Contributor

deads2k commented Aug 9, 2018

Seems reasonable to me

@tpepper
Copy link
Member

tpepper commented Aug 9, 2018

Should the release note include brief mention that its functionality is instead found in kube-apiserver?

Otherwise looks good to me.

@dims
Copy link
Member Author

dims commented Aug 9, 2018

@tpepper done

@lavalamp
Copy link
Member

lavalamp commented Aug 9, 2018

I do not agree that the standalone binary is useless.

It is fine to remove it from the main build and the things we publish. We needn't make it impossible to build, though? Can I still build it separately after this change?

@dims
Copy link
Member Author

dims commented Aug 9, 2018

@lavalamp Just the release oriented stuff is being removed. Please take a peek at the commit.

@dims
Copy link
Member Author

dims commented Aug 13, 2018

/assign @ixdy

@lavalamp
Copy link
Member

Just the release oriented stuff is being removed. Please take a peek at the commit.

I had, it's not obvious that those files only affect the release.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 66177, 66185, 67136, 67157, 65065). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit b9c17ec into kubernetes:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishh vishh Awaiting requested review from vishh

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@lavalamp lavalamp

@cblecker cblecker

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@dims @sttts @deads2k @tpepper @lavalamp @k8s-ci-robot @fejta-bot @k8s-github-robot @cblecker @ixdy