Fail container start if its requested device plugin resource is unknown. #67145
Conversation
k8s-ci-robot
added
release-note
|
/sig node |
k8s-ci-robot
added
the
sig/node
|
/assign @vikaschoudhary16 @RenaudWasTaken |
k8s-ci-robot
added
the
approved
|
Are failed container "retried" or is this up to another abstraction? |
|
Kubelet will retry with exponential backoff latency. |
have cached option state to make sure the device plugin resource is in ready state when we start the container.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiayingz, vikaschoudhary16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all Tests are more than 96 hours old. Re-running tests. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
|
This seems to have caused the device plugin tests to fail: https://k8s-testgrid.appspot.com/sig-node-kubelet#kubelet-serial-gce-e2e&include-filter-by-regex=DevicePlugin |
|
Ah right. I need to update the device plugin e2e_node test to cope with this behavior change. I will send a PR to fix that. @dashpole thanks a lot for the notification! |
With the change, Kubelet device manager now checks whether it has cached option state for the requested device plugin resource to make sure the resource is in ready state when we start the container.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #67107
Special notes for your reviewer:
Release note: