Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate crictl config for preload as well. #66877

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Generate crictl config for preload as well. #66877

merged 1 commit into from
Aug 2, 2018

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Aug 1, 2018 •
edited
Loading

Generate /etc/crictl.yaml also when crictl is preloaded.

Signed-off-by: Lantao Liu lantaol@google.com

Release note:

Fix a bug on GCE that /etc/crictl.yaml is not generated when crictl is preloaded.

@Random-Liu
Generate crictl config for preload as well.
7dc1e9a 
Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 1, 2018
@Random-Liu Random-Liu added this to the v1.11 milestone Aug 1, 2018
@Random-Liu Random-Liu added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/gcp and removed milestone/incomplete-labels labels Aug 1, 2018
@Random-Liu Random-Liu added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 1, 2018
@yujuhong
Copy link
Contributor

yujuhong commented Aug 1, 2018

/lgtm

Please update the release note for cherrypicks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2018
@Random-Liu
Copy link
Member Author

Random-Liu commented Aug 1, 2018 •
edited
Loading

/cc @foxish for cherrypick approval.
/cc @dchen1107 for approval.

@Random-Liu Random-Liu assigned foxish, dchen1107 and yujuhong and unassigned dchen1107 and yujuhong Aug 1, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@Random-Liu @dchen1107 @foxish @yujuhong

Pull Request Labels
  • sig/gcp sig/node: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, Random-Liu, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 2, 2018
@yujuhong
Copy link
Contributor

yujuhong commented Aug 2, 2018

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@foxish
Copy link
Contributor

foxish commented Aug 2, 2018

@Random-Liu I don't see a cherrypick PR yet.

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit cd31266 into kubernetes:master Aug 2, 2018
@Random-Liu Random-Liu deleted the crictl-yaml-for-preload branch August 2, 2018 07:37
@Random-Liu Random-Liu mentioned this pull request Aug 2, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Aug 3, 2018
Merge pull request #66893 from Random-Liu/automated-cherry-pick-of-#6…
9ec15a5 
…6877-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #66877: Generate crictl config for preload as well.

Cherry pick of #66877 on release-1.11.

#66877: Generate crictl config for preload as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingax10 jingax10 Awaiting requested review from jingax10

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@foxish foxish

@dchen1107 dchen1107

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
7 participants
@Random-Liu @yujuhong @k8s-github-robot @dchen1107 @k8s-ci-robot @fejta-bot @foxish